Fix shellcheck issue in userid-validation
Shellcheck correctly notes that that xs in comparisons are uneeded
```
[1mIn jenkins/userid-validation line 25:[0m [0mif [
"x${COMMITTER_EMAIL}" == "x" ]; then[0m [32m ^-------------------^
SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a
purpose.[0m
[1mDid you mean: [0m if [ "${COMMITTER_EMAIL}" == "" ]; then
[1mIn jenkins/userid-validation line 38:[0m [0mif [
"x${COMMITTER_USERNAME}" == "x" ]; then[0m [32m
^----------------------^ SC2268 (style): Avoid x-prefix in comparisons
as it no longer serves a purpose.[0m
```
Do as the robot commands.
Tested: Not sure how to test this, although it's pretty trivial.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idfa440f146e90f77e7b84eb0ff5f2d68f6b612c1
diff --git a/jenkins/userid-validation b/jenkins/userid-validation
index 0ed259f..3569b26 100755
--- a/jenkins/userid-validation
+++ b/jenkins/userid-validation
@@ -22,7 +22,7 @@
# shellcheck disable=2086 # GERRIT_COMMAND is purposefully wordsplit.
COMMITTER_EMAIL=$(${GERRIT_COMMAND}/a/changes/${GERRIT_PROJECT/\//%2F}~${GERRIT_BRANCH}~${GERRIT_CHANGE_ID}/revisions/${GERRIT_PATCHSET_REVISION}/commit | python2 -c "import sys, json; sys.stdin.read(4); print(json.load(sys.stdin)['committer']['email'])")
-if [ "x${COMMITTER_EMAIL}" == "x" ]; then
+if [ "${COMMITTER_EMAIL}" = "" ]; then
echo "Unable to find committer."
"${GERRIT_SSH_CMD[@]}" review \
"${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \
@@ -35,7 +35,7 @@
COMMITTER_USERNAME=$(${GERRIT_COMMAND}/a/accounts/${COMMITTER_EMAIL} | python2 -c "import sys, json; sys.stdin.read(4); print(json.load(sys.stdin)['username'])")
#COMMITTER_USERNAME=`${GERRIT_COMMAND}/a/accounts/${COMMITTER_EMAIL}`
echo "USERNAME: $COMMITTER_USERNAME"
-if [ "x${COMMITTER_USERNAME}" == "x" ]; then
+if [ "${COMMITTER_USERNAME}" = "" ]; then
echo "Unable to determine github user for ${COMMITTER_EMAIL}."
"${GERRIT_SSH_CMD[@]}" review \
"${GERRIT_CHANGE_NUMBER},${GERRIT_PATCHSET_NUMBER}" \