Gitiles
Code Review Sign In
gerrit.openbmc.org / mdmillerii / openbmc / 2fdc70c68048c6883323e4d1d6ef3ab34913478b
commit2fdc70c68048c6883323e4d1d6ef3ab34913478b[log] [tgz]
authorAndrew Geissler <geissonator@yahoo.com>Fri Jan 18 11:00:48 2019 -0600
committerBrad Bishop <bradleyb@fuzziesquirrel.com>Wed Feb 13 17:04:16 2019 -0500
treeab6b5dfa461ac4b8a6f3ff9a6c74bbdd168dd6cf
parent4686bb5598712b6c7f5541c9ac5e7ac75c8e07df [diff]
Ensure ipmid doesn't start until on dbus

Other services rely on phosphor-ipmi-host providing needed dbus
interfaces once its been started. Due to other services providing
identical dbus object paths, the normal mapper wait services are not an
option here.

Ensure systemd does not consider this service active until it has
registered the host control dbus object.

I'm working on a long term fix to this in
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-objmgr/+/17990/
(a refactor with unit tests) and
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-objmgr/+/17837/
(close race condition due to introspection) but I think this change here
makes things better overall so I'd like to get it merged

Testing:
Verified systemd now waits for ipmid to really get up and running and
ran through HW CI

Jan 18 19:56:00 witherspoon systemd[1]: Starting Phosphor Inband IPMI...
Jan 18 19:56:03 witherspoon ipmid[1336]: JSON file not found
Jan 18 19:56:09 witherspoon systemd[1]: Started Phosphor Inband IPMI.

I had our internal test team try out this patch on a Romulus. They were
seeing this issue this is trying to fix on a very regular basis. With
this change, they completed 265 successful boot tests. The ipmid process
does host 2 well-know names, openbmc_project.Ipmi.Host and
xyz.openbmc_project.Control.Host. I verified via a bus capture that
xyz.openbmc_project.Control.Host is the last one to be put on the bus.

Resolves openbmc/phosphor-state-manager#2

(From meta-phosphor rev: bea22141ca95b38f30adcec248a853d3d268af79)

Change-Id: I532b31647951045adc8cbd0141e8630cdc350e27
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
1 file changed
tree: ab6b5dfa461ac4b8a6f3ff9a6c74bbdd168dd6cf
  1. meta-arm/
  2. meta-aspeed/
  3. meta-evb/
  4. meta-facebook/
  5. meta-google/
  6. meta-hxt/
  7. meta-ibm/
  8. meta-ingrasys/
  9. meta-inspur/
  10. meta-intel/
  11. meta-inventec/
  12. meta-mellanox/
  13. meta-nuvoton/
  14. meta-openembedded/
  15. meta-openpower/
  16. meta-phosphor/
  17. meta-portwell/
  18. meta-qualcomm/
  19. meta-quanta/
  20. meta-raspberrypi/
  21. meta-security/
  22. meta-x86/
  23. meta-xilinx/
  24. poky/
  25. bitbake ⇨ poky/bitbake/
  26. LICENSE ⇨ poky/LICENSE
  27. meta ⇨ poky/meta
  28. meta-poky ⇨ poky/meta-poky/
  29. meta-skeleton ⇨ poky/meta-skeleton
  30. oe-init-build-env ⇨ poky/oe-init-build-env
  31. scripts ⇨ poky/scripts/
  32. .gitignore
  33. .gitreview
  34. .templateconf
  35. MAINTAINERS
  36. openbmc-env
  37. README.md
  38. setup
README.md

OpenBMC

Build Status

The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.

Setting up your OpenBMC project

1) Prerequisite

  • Ubuntu 14.04
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
  • Fedora 28
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake rpcgen
sudo dnf groupinstall "C Development Tools and Libraries"

2) Download the source

git clone git@github.com:openbmc/openbmc.git
cd openbmc

3) Target your hardware

Any build requires an environment variable known as TEMPLATECONF to be set to a hardware target. You can see all of the known targets with find meta-* -name local.conf.sample. Choose the hardware target and then move to the next step. Additional examples can be found in the OpenBMC Cheatsheet

MachineTEMPLATECONF
Palmettometa-ibm/meta-palmetto/conf
Zaiusmeta-ingrasys/meta-zaius/conf
Witherspoonmeta-ibm/meta-witherspoon/conf
Romulusmeta-ibm/meta-romulus/conf

As an example target Palmetto

export TEMPLATECONF=meta-ibm/meta-palmetto/conf

4) Build

. openbmc-env
bitbake obmc-phosphor-image

Additional details can be found in the docs repository.

Build Validation and Testing

Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.

Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.

Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.

Submitting Patches

Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.

Bug Reporting

Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.

Features of OpenBMC

Feature List

  • REST Management
  • IPMI
  • SSH based SOL
  • Power and Cooling Management
  • Event Logs
  • Zeroconf discoverable
  • Sensors
  • Inventory
  • LED Management
  • Host Watchdog
  • Simulation
  • Code Update Support for multiple BMC/BIOS images

Features In Progress

  • Full IPMI 2.0 Compliance with DCMI
  • Verified Boot
  • HTML5 Java Script Web User Interface
  • BMC RAS

Features Requested but need help

  • OpenCompute Redfish Compliance
  • OpenBMC performance monitoring
  • cgroup user management and policies
  • Remote KVM
  • Remote USB
  • OpenStack Ironic Integration
  • QEMU enhancements

Finding out more

Dive deeper in to OpenBMC by opening the docs repository.

Contact