| commit | 3fb3920d7587fc82f28a51a96fbbf7ff81f97415 | [log] [tgz] |
|---|---|---|
| author | Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> | Wed Jul 19 01:03:13 2017 -0500 |
| committer | Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> | Mon Jul 24 12:24:22 2017 -0500 |
| tree | 295605e966b3d976f7c1b09700e5200ac7d03092 | |
| parent | 25065d162ecdda17519a773dedf35ae28aa2bdc8 [diff] |
Fix a bug in driving LED during PowerOn and PowerOff As part of PowerOn, group 'power_on' gets asserted via a service file that is associated with PowerOn and that results in driving corresponding physical LEDs. This works fine for a single PowerOn and does not work if there is a PowerOff followed by a PowerOn. Service file had RemainAfterExit set and did not have a stop condition. This commit puts a Conflicts relationship with appropriate stop service file and vice versa. Fixes openbmc/openbmc#1918 Change-Id: Ie0e6b554b3ab7beacd3ad15a0ff76e4d6481f648 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
diff --git a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service index 7c0207c..36a4430 100644 --- a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service +++ b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service
@@ -2,6 +2,7 @@ Description=Assert %i LED Wants=mapper-wait@-xyz-openbmc_project-led-groups-%i.service After=mapper-wait@-xyz-openbmc_project-led-groups-%i.service +Conflicts=obmc-led-group-stop@%i.service [Service] Type=oneshot
diff --git a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service index 4ddf0f8..e7799f3 100644 --- a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service +++ b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service
@@ -2,6 +2,7 @@ Description=Assert %i LED Wants=mapper-wait@-xyz-openbmc_project-led-groups-%i.service After=mapper-wait@-xyz-openbmc_project-led-groups-%i.service +Conflicts=obmc-led-group-start@%i.service [Service] Type=oneshot