meta-hpe: fix shellcheck issues
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I30885f8c2577c3c2aa333a61210e6738fbf016c7
diff --git a/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable.bb b/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable.bb
index 58cc921..c0f5d64 100644
--- a/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable.bb
+++ b/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable.bb
@@ -14,6 +14,8 @@
SRC_URI += "file://host-boot-enable.service"
SRC_URI += "file://host-boot-enable.sh"
+RDEPENDS:${PN}:append = " bash"
+
do_install() {
install -d ${D}${bindir}
install -m 0755 ${WORKDIR}/host-boot-enable.sh ${D}${bindir}
diff --git a/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh b/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
index 1798607..c43ed34 100644
--- a/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
+++ b/meta-hpe/meta-common/recipes-hpe/host/host-boot-enable/host-boot-enable.sh
@@ -1,10 +1,10 @@
-#!/bin/sh
+#!/bin/bash
findmtd() {
m=$(grep -xl "$1" /sys/class/mtd/*/name)
m=${m%/name}
m=${m##*/}
- echo $m
+ echo "$m"
}
rom_lists=(host-prime host-second vrom-prime vrom-second)
@@ -12,27 +12,27 @@
for f in "${rom_lists[@]}"
do
- image=$(findmtd ${f})
+ image=$(findmtd "${f}")
if test -z "$image"
then
echo "Unable to find mtd partition for ${f}"
exit 1
fi
- rom_mtd_list+=($image)
+ rom_mtd_list+=("$image")
done
#enable vrom
# host-prime to vrom-prime
-dd if=/dev/${rom_mtd_list[0]} of=/dev/${rom_mtd_list[2]}
+dd if="/dev/${rom_mtd_list[0]}" of="/dev/${rom_mtd_list[2]}"
# host-second to vrom-second
-dd if=/dev/${rom_mtd_list[1]} of=/dev/${rom_mtd_list[3]}
+dd if="/dev/${rom_mtd_list[1]}" of="/dev/${rom_mtd_list[3]}"
echo 0x1800008a > /sys/class/soc/srom/vromoff
val=$(( ("$(devmem 0xd1000006 8)" && 0xff) | 0x04 ))
devmem 0xd1000006 8 $val
devmem 0xd1000018 8 0xff
-while [ true ]
+while true
do
devmem 0xd100000f 8 0x14
sleep 1