| commit | 8c2262344c1fc1f8708f4a44af395ea8c49f12e2 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Sat Apr 15 20:05:21 2023 -0500 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Thu Apr 27 16:16:12 2023 +0000 |
| tree | c77f039128cd588f75b89a2272248960b3482baf | |
| parent | bd58e95482128fa5aefb97125613e6b23723e85e [diff] |
meta-quanta: fix shellcheck issues Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I189baf142cc86d44ebbf615edd3bb0ec1785be8d
diff --git a/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh b/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh index 1bff18d..97f9cfe 100644 --- a/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh +++ b/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-check-host-state.sh
@@ -5,8 +5,8 @@ dbus-monitor --system type='signal',interface='org.freedesktop.DBus.Properties',\ member='PropertiesChanged',arg0namespace='xyz.openbmc_project.State.Chassis' | \ while read -r line; do - grep -q member <<< $line && continue - if grep -q $state <<< $line; then + grep -q member <<< "$line" && continue + if grep -q $state <<< "$line"; then echo "Setting failsafe assuming host is off" >&2 systemctl start --no-block gbs-host-s5-set-failsafe fi
diff --git a/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh b/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh index bcd1d2c..8d6f774 100644 --- a/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh +++ b/meta-quanta/meta-gbs/recipes-google/acpi-power-state/acpi-power-state-daemon/gbs-set-failsafe.sh
@@ -22,10 +22,10 @@ exit 1 fi -zone_num="$(busctl tree xyz.openbmc_project.State.FanCtrl | grep zone | wc -l)" +zone_num="$(busctl tree xyz.openbmc_project.State.FanCtrl | grep -c zone)" result=0 -for (( i = 0; i < ${zone_num}; i++ )); do +for (( i = 0; i < zone_num; i++ )); do retries=4 busctl_error=-1 @@ -39,7 +39,7 @@ sleep 1 fi - let retries-=1 + (( retries-=1 )) || true done if (( busctl_error != 0 )); then