| commit | 90e792a45ac1ca2fbd237df40212308abe90c09f | [log] [tgz] |
|---|---|---|
| author | Thang Q. Nguyen <thang@os.amperecomputing.com> | Fri Apr 07 16:26:32 2023 +0700 |
| committer | Thang Q. Nguyen <thang@os.amperecomputing.com> | Mon Apr 10 01:41:27 2023 +0000 |
| tree | d97171c6b0cef29672e42f0443727424480544cd | |
| parent | d1d733b5bc0348de3752efeed45d1218cde62f37 [diff] |
meta-ampere: remove env call from service file We are suppose to use direct executable calls in service files rather than indirections through /bin/env (See Anti-patterns). Tested: - Check related services to work like before Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com> Change-Id: Idb494ce781fa1bdcac176cd89612e6016e6e04d9
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere-sysfw-hang-handler.service b/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere-sysfw-hang-handler.service index 5eeaf5c..7040b3e 100644 --- a/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere-sysfw-hang-handler.service +++ b/meta-ampere/meta-mitchell/recipes-ampere/host/ampere-sysfw-hang-handler/ampere-sysfw-hang-handler.service
@@ -6,7 +6,7 @@ [Service] Type=simple -ExecStart=/usr/bin/env ampere_sysfw_hang_handler.sh +ExecStart=/usr/sbin/ampere_sysfw_hang_handler.sh SyslogIdentifier=ampere_sysfw_hang [Install]
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-mac-update/ampere_update_mac.service b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-mac-update/ampere_update_mac.service index f68f029..c816fac 100644 --- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-mac-update/ampere_update_mac.service +++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-mac-update/ampere_update_mac.service
@@ -6,7 +6,7 @@ StartLimitBurst=5 [Service] -ExecStart=/usr/bin/env ampere_update_mac.sh eth0 14 80 +ExecStart=/usr/sbin/ampere_update_mac.sh eth0 14 80 SyslogIdentifier=ampere_update_mac.sh RemainAfterExit=yes Restart=on-failure
diff --git a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere-bmc-heartbeat.service b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere-bmc-heartbeat.service index 735d113..9a860f3 100644 --- a/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere-bmc-heartbeat.service +++ b/meta-ampere/meta-mitchell/recipes-ampere/platform/ampere-platform-init/ampere-bmc-heartbeat.service
@@ -4,7 +4,7 @@ [Service] Type=simple Restart=always -ExecStart=/usr/bin/env ampere_bmc_heartbeat.sh +ExecStart=/usr/sbin/ampere_bmc_heartbeat.sh SyslogIdentifier = "ampere-bmc-heartbeat" [Install]