commit 9b8716888b838a9985a313d8c2ed287497d851e7
author Patrick Williams <patrick@stwcx.xyz> Fri Apr 14 15:08:08 2023 -0500
committer Patrick Williams <patrick@stwcx.xyz> Wed Apr 19 01:37:09 2023 +0000
tree 98f2cbb238baaed45d1b814a7a012ce2bf7b3779
parent 51d6af4e64f0ca08e6b8322b0cac94b93e5d5e27

meta-ibm: fix some shellcheck issues

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iced76041c1207dc9ab28a83fd849ba3cd0a07bb5

meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh

diff --git a/meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh b/meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh
index 85d7741..c35a61b 100644
--- a/meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh
+++ b/meta-ibm/recipes-phosphor/chassis/vrm-control/ibm-ac-server/ir35221-unbind-bind.sh
@@ -9,7 +9,7 @@
 platform_path="/sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/"
 
 unbind_driver () {
-    echo $1 > $driver_path/unbind
+    echo "$1" > $driver_path/unbind
 }
 
 bind_driver () {
@@ -19,7 +19,8 @@
     until [ $tries -ge $max_retries ]; do
         tries=$((tries+1))
         ret=0
-        echo $device > $driver_path/bind || ret=$?
+        # shellcheck disable=SC2320
+        echo "$device" > $driver_path/bind || ret=$?
         if [ $ret -ne 0 ]; then
             echo "VRM $1 bind failed. Try $tries"
             sleep 1
@@ -29,7 +30,7 @@
     done
 
     #Script will return a nonzero value if any binds fail.
-    if [ $ret -ne 0 ]; then
+    if [ "$ret" -ne 0 ]; then
         status=$ret
     fi
 }
@@ -78,4 +79,4 @@
     fi
 fi
 
-exit $status
+exit "$status"