meta-facebook: remove excess override syntaxes
When a bbappend file is already in a meta-machine layer, there is no
reason for extra ":machine" override syntax usage. Remove them all.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I610e72633adb5bc36b63fe2b727e394c61070185
diff --git a/meta-facebook/meta-bletchley/recipes-bletchley/plat-svc/plat-svc_0.1.bb b/meta-facebook/meta-bletchley/recipes-bletchley/plat-svc/plat-svc_0.1.bb
index ecf232f..b1508df 100644
--- a/meta-facebook/meta-bletchley/recipes-bletchley/plat-svc/plat-svc_0.1.bb
+++ b/meta-facebook/meta-bletchley/recipes-bletchley/plat-svc/plat-svc_0.1.bb
@@ -27,4 +27,4 @@
install -m 0755 ${WORKDIR}/bletchley-host-state-monitor ${D}${libexecdir}
}
-SYSTEMD_OVERRIDE:${PN}:bletchley += "bletchley-sys-init.conf:bletchley-sys-init.service.d/bletchley-sys-init.conf"
+SYSTEMD_OVERRIDE:${PN} += "bletchley-sys-init.conf:bletchley-sys-init.service.d/bletchley-sys-init.conf"
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/chassis/obmc-phosphor-buttons_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/chassis/obmc-phosphor-buttons_%.bbappend
index bf19fe7..91e994e 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/chassis/obmc-phosphor-buttons_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/chassis/obmc-phosphor-buttons_%.bbappend
@@ -1,8 +1,8 @@
-FILESEXTRAPATHS:append:bletchley := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS:append := "${THISDIR}/${PN}:"
SRC_URI += "file://gpio_defs.json"
-do_install:append:bletchley() {
+do_install:append() {
install -d ${D}${sysconfdir}/default/obmc/gpio/
install -m 0644 ${WORKDIR}/gpio_defs.json ${D}/${sysconfdir}/default/obmc/gpio/
}
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/fans/phosphor-pid-control_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/fans/phosphor-pid-control_%.bbappend
index 8b63026..0f66bba 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/fans/phosphor-pid-control_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/fans/phosphor-pid-control_%.bbappend
@@ -1,9 +1,9 @@
-FILESEXTRAPATHS:prepend:bletchley := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
-FILES:${PN}:append:bletchley = " ${datadir}/swampd"
-FILES:${PN}:append:bletchley = " ${systemd_system_unitdir}/phosphor-pid-control.service.d/*.conf"
+FILES:${PN}:append = " ${datadir}/swampd"
+FILES:${PN}:append = " ${systemd_system_unitdir}/phosphor-pid-control.service.d/*.conf"
-do_install:append:bletchley() {
+do_install:append() {
override_dir="${D}${systemd_system_unitdir}/phosphor-pid-control.service.d"
override_file="${override_dir}/10-bletchley.conf"
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor_%.bbappend
index c65e729..4ee7437 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/gpio/phosphor-gpio-monitor_%.bbappend
@@ -7,15 +7,15 @@
INSTFMT_PRESENT = "phosphor-gpio-presence@presence-sled{0}.service"
PRESENT_TGT = "multi-user.target"
FMT_PRESENT = "../${TMPL_PRESENT}:${PRESENT_TGT}.requires/${INSTFMT_PRESENT}"
-SYSTEMD_LINK:${PN}-presence:append:bletchley = " ${@compose_list(d, 'FMT_PRESENT', 'OBMC_HOST_INSTANCES')}"
+SYSTEMD_LINK:${PN}-presence:append = " ${@compose_list(d, 'FMT_PRESENT', 'OBMC_HOST_INSTANCES')}"
# Add environment file
SLED_PRESENT_ENV_FMT = "obmc/gpio/presence-sled{0}.conf"
-SYSTEMD_ENVIRONMENT_FILE:${PN}-presence:bletchley = " ${@compose_list(d, 'SLED_PRESENT_ENV_FMT', 'OBMC_HOST_INSTANCES')}"
+SYSTEMD_ENVIRONMENT_FILE:${PN}-presence = " ${@compose_list(d, 'SLED_PRESENT_ENV_FMT', 'OBMC_HOST_INSTANCES')}"
GPIO_PRESENCE_SLED_CONF="/etc/default/obmc/gpio/%i.conf"
-do_install:append:bletchley(){
+do_install:append(){
# modify ConditionPathExists and EnvironmentFile to correct filepath
sed -i -e "s,ConditionPathExists=.*,ConditionPathExists=${GPIO_PRESENCE_SLED_CONF},g" ${D}${systemd_system_unitdir}/phosphor-gpio-presence@.service
sed -i -e "s,EnvironmentFile=.*,EnvironmentFile=${GPIO_PRESENCE_SLED_CONF},g" ${D}${systemd_system_unitdir}/phosphor-gpio-presence@.service
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-fru_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-fru_%.bbappend
index 3d795c8..ce94809 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-fru_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-fru_%.bbappend
@@ -1,10 +1,10 @@
inherit obmc-phosphor-systemd
-FILESEXTRAPATHS:prepend:bletchley := "${THISDIR}/${PN}:"
+FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
-DEPENDS:append:bletchley = " bletchley-yaml-config"
+DEPENDS:append = " bletchley-yaml-config"
-IPMI_FRU_YAML:bletchley = "${STAGING_DIR_HOST}${datadir}/bletchley-yaml-config/ipmi-fru-read.yaml"
+IPMI_FRU_YAML = "${STAGING_DIR_HOST}${datadir}/bletchley-yaml-config/ipmi-fru-read.yaml"
EEPROM_NAMES = "bmc"
@@ -14,11 +14,11 @@
EEPROMS_ESCAPED = "${@compose_list(d, 'EEPROM_ESCAPEDFMT', 'EEPROM_NAMES')}"
ENVFMT = "obmc/eeproms/{0}"
-SYSTEMD_ENVIRONMENT_FILE:${PN}:append:bletchley := " ${@compose_list(d, 'ENVFMT', 'EEPROMS')}"
+SYSTEMD_ENVIRONMENT_FILE:${PN}:append := " ${@compose_list(d, 'ENVFMT', 'EEPROMS')}"
TMPL = "obmc-read-eeprom@.service"
TGT = "${SYSTEMD_DEFAULT_TARGET}"
INSTFMT = "obmc-read-eeprom@{0}.service"
FMT = "../${TMPL}:${TGT}.wants/${INSTFMT}"
-SYSTEMD_LINK:${PN}:append:bletchley := " ${@compose_list(d, 'FMT', 'EEPROMS_ESCAPED')}"
+SYSTEMD_LINK:${PN}:append := " ${@compose_list(d, 'FMT', 'EEPROMS_ESCAPED')}"
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-host_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-host_%.bbappend
index 032cdaf..dcab003 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-host_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-host_%.bbappend
@@ -1,11 +1,11 @@
-DEPENDS:append:bletchley = " bletchley-yaml-config"
+DEPENDS:append = " bletchley-yaml-config"
-EXTRA_OEMESON:bletchley = " \
+EXTRA_OEMESON = " \
-Dfru-yaml-gen=${STAGING_DIR_HOST}${datadir}/bletchley-yaml-config/ipmi-fru-read.yaml \
"
# host watchdog does not support on bletchley
-RDEPENDS:${PN}:remove:bletchley = "phosphor-watchdog"
+RDEPENDS:${PN}:remove = "phosphor-watchdog"
# bletchley doesn't have IPMI support, skip xyz.openbmc_project.Ipmi.Internal.SoftPowerOff.service
SOFT_SVC = ""
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-ipmb_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-ipmb_%.bbappend
index ae8a15d..b7f09e9 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-ipmb_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/ipmi/phosphor-ipmi-ipmb_%.bbappend
@@ -1 +1 @@
-IPMB_CHANNELS:bletchley = "/dev/ipmb-13"
+IPMB_CHANNELS = "/dev/ipmb-13"
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/sensors/dbus-sensors_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/sensors/dbus-sensors_%.bbappend
index f409fbf..fd5c1ed 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/sensors/dbus-sensors_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/sensors/dbus-sensors_%.bbappend
@@ -1,6 +1,6 @@
FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
-PACKAGECONFIG:bletchley = " \
+PACKAGECONFIG = " \
adcsensor \
fansensor \
hwmontempsensor \
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/sensors/phosphor-nvme_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/sensors/phosphor-nvme_%.bbappend
index 84df1a1..c550d59 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/sensors/phosphor-nvme_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/sensors/phosphor-nvme_%.bbappend
@@ -2,15 +2,15 @@
inherit obmc-phosphor-systemd
-SRC_URI:append:bletchley = " \
+SRC_URI:append = " \
file://nvme-json-rewrite \
file://nvme-json-rewrite.conf \
file://nvme_config.json \
"
-RDEPENDS:${PN}:bletchley += "bash"
+RDEPENDS:${PN} += "bash"
-do_install:append:bletchley() {
+do_install:append() {
install -d ${D}${libexecdir}/${PN}/
install -m 0755 ${WORKDIR}/nvme-json-rewrite ${D}${libexecdir}/${PN}/
@@ -18,6 +18,6 @@
install -m 0644 -D ${WORKDIR}/nvme_config.json ${D}${sysconfdir}/nvme
}
-SYSTEMD_OVERRIDE:${PN}:append:bletchley = " \
+SYSTEMD_OVERRIDE:${PN}:append = " \
nvme-json-rewrite.conf:xyz.openbmc_project.nvme.manager.service.d/nvme-json-rewrite.conf \
"
diff --git a/meta-facebook/meta-bletchley/recipes-phosphor/state/phosphor-state-manager_%.bbappend b/meta-facebook/meta-bletchley/recipes-phosphor/state/phosphor-state-manager_%.bbappend
index 1cc021a..dd2711e 100644
--- a/meta-facebook/meta-bletchley/recipes-phosphor/state/phosphor-state-manager_%.bbappend
+++ b/meta-facebook/meta-bletchley/recipes-phosphor/state/phosphor-state-manager_%.bbappend
@@ -1,6 +1,6 @@
FILESEXTRAPATHS:prepend := "${THISDIR}/${PN}:"
-SRC_URI:append:bletchley = " \
+SRC_URI:append = " \
file://chassis-powercycle \
file://chassis-powercycle@.service \
file://chassis-poweroff@.service \
@@ -9,10 +9,10 @@
file://host-poweron@.service \
"
-RDEPENDS:${PN}-discover:append:bletchley = " bletchley-common-tool"
-RDEPENDS:${PN}:append:bletchley = " bash motor-ctrl"
+RDEPENDS:${PN}-discover:append = " bletchley-common-tool"
+RDEPENDS:${PN}:append = " bash motor-ctrl"
-do_install:append:bletchley() {
+do_install:append() {
install -d ${D}${systemd_system_unitdir}
install -m 0644 ${WORKDIR}/*.service ${D}${systemd_system_unitdir}/
@@ -20,8 +20,8 @@
install -m 0755 ${WORKDIR}/chassis-powercycle ${D}${libexecdir}/${PN}/
}
-FILES:${PN}:append:bletchley = " ${systemd_system_unitdir}"
-FILES:${PN}:append:bletchley = " ${libexecdir}/${PN}"
+FILES:${PN}:append= " ${systemd_system_unitdir}"
+FILES:${PN}:append= " ${libexecdir}/${PN}"
# Because Bletchley does not have IPMI between Bmc & Host, the Host init
# state will set to Off after Bmc booted. We require an extra service to
@@ -29,14 +29,14 @@
# doing any power action or power policy restore.
BLETCHLEY_SYS_ST_INIT_CONF_FMT = "bletchley-system-state-init.conf:phosphor-discover-system-state@{0}.service.d/bletchley-system-state-init.conf"
-SYSTEMD_OVERRIDE:${PN}-discover:bletchley += "${@compose_list_zip(d, 'BLETCHLEY_SYS_ST_INIT_CONF_FMT', 'OBMC_HOST_INSTANCES')}"
+SYSTEMD_OVERRIDE:${PN}-discover += "${@compose_list_zip(d, 'BLETCHLEY_SYS_ST_INIT_CONF_FMT', 'OBMC_HOST_INSTANCES')}"
-PACKAGECONFIG:remove:bletchley = "only-run-apr-on-power-loss"
+PACKAGECONFIG:remove = "only-run-apr-on-power-loss"
#======================
# Workaround for bletchley
#======================
-CHASSIS_DEFAULT_TARGETS:remove:bletchley = " \
+CHASSIS_DEFAULT_TARGETS:remove = " \
obmc-chassis-powerreset@{}.target.requires/phosphor-reset-chassis-on@{}.service \
obmc-chassis-powerreset@{}.target.requires/phosphor-reset-chassis-running@{}.service \
obmc-chassis-poweroff@{}.target.requires/obmc-power-stop@{}.service \
@@ -46,4 +46,4 @@
HOST_DEFAULT_TARGETS:append = " \
obmc-host-startmin@{}.target.wants/host-poweron@{}.service \
obmc-host-stop@{}.target.wants/host-poweroff@{}.service \
-"
\ No newline at end of file
+"