Gitiles
Code Review Sign In
gerrit.openbmc.org / mdmillerii / openbmc / b4440998270e387b15c0e0a2a7737bde8d4ce91e
commitb4440998270e387b15c0e0a2a7737bde8d4ce91e[log] [tgz]
authorMatt Spinler <spinler@us.ibm.com>Mon Jun 04 16:25:43 2018 -0500
committerBrad Bishop <bradleyb@fuzziesquirrel.com>Tue Jun 19 13:48:03 2018 +0000
tree88e3ef6ef506df01126d7cc85ff91d1fb385d7cc
parente87ca3b1256c82cbfaea9f3b54f63b6c794654ca [diff]
wspoon: Improve fan error resolving rules

The previous phosphor-dbus-monitor rules would only watch
for the functional property to change on a fan, and then
resolve errors for that fan if the property changed to true.

This change will watch for both present and functional property
changes, and resolve fan errors if both properties are true at
that time.

This closes the window of where if a fan is removed long enough for
the present property to change to false but replaced fast enough
that the functional property always stays true then the NotPresent
error that was created will never get resolved so the fault LEDs
won't turn off.

Resolves openbmc/openbmc#3231

Tested: Various combinations of Present/Functional property state
        changes and also fan plugs/unplugs.

Change-Id: I3255c0510b95509810b018a2a71d307bd7d4a946
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
1 file changed
tree: 88e3ef6ef506df01126d7cc85ff91d1fb385d7cc
  1. import-layers/
  2. meta-openbmc-bsp/
  3. meta-openbmc-machines/
  4. meta-phosphor/
  5. bitbake ⇨ import-layers/yocto-poky/bitbake
  6. documentation ⇨ import-layers/yocto-poky/documentation
  7. LICENSE ⇨ import-layers/yocto-poky/LICENSE
  8. meta ⇨ import-layers/yocto-poky/meta
  9. meta-poky ⇨ import-layers/yocto-poky/meta-poky
  10. meta-selftest ⇨ import-layers/yocto-poky/meta-selftest
  11. meta-skeleton ⇨ import-layers/yocto-poky/meta-skeleton
  12. meta-yocto-bsp ⇨ import-layers/yocto-poky/meta-yocto-bsp
  13. oe-init-build-env ⇨ import-layers/yocto-poky/oe-init-build-env
  14. oe-init-build-env-memres ⇨ import-layers/yocto-poky/oe-init-build-env-memres
  15. scripts ⇨ import-layers/yocto-poky/scripts
  16. .gitignore
  17. .gitreview
  18. .templateconf
  19. MAINTAINERS
  20. openbmc-env
  21. README.md
  22. setup
README.md

OpenBMC

Build Status

The OpenBMC project can be described as a Linux distribution for embedded devices that have a BMC; typically, but not limited to, things like servers, top of rack switches or RAID appliances. The OpenBMC stack uses technologies such as Yocto, OpenEmbedded, systemd, and D-Bus to allow easy customization for your server platform.

Setting up your OpenBMC project

1) Prerequisite

  • Ubuntu 14.04
sudo apt-get install -y git build-essential libsdl1.2-dev texinfo gawk chrpath diffstat
  • Fedora 23
sudo dnf install -y git patch diffstat texinfo chrpath SDL-devel bitbake
sudo dnf groupinstall "C Development Tools and Libraries"

2) Download the source

git clone git@github.com:openbmc/openbmc.git
cd openbmc

3) Target your hardware

Any build requires an environment variable known as TEMPLATECONF to be set to a hardware target. OpenBMC has placed all known hardware targets in a standard directory structure meta-openbmc-machines/meta-[architecture]/meta-[company]/meta-[target]. You can see all of the known targets with find meta-openbmc-machines -type d -name conf. Choose the hardware target and then move to the next step. Additional examples can be found in the OpenBMC Cheatsheet

MachineTEMPLATECONF
Palmettometa-openbmc-machines/meta-openpower/meta-ibm/meta-palmetto/conf
Zaiusmeta-openbmc-machines/meta-openpower/meta-ingrasys/meta-zaius/conf
Witherspoonmeta-openbmc-machines/meta-openpower/meta-ibm/meta-witherspoon/conf

As an example target Palmetto

export TEMPLATECONF=meta-openbmc-machines/meta-openpower/meta-ibm/meta-palmetto/conf

4) Build

. openbmc-env
bitbake obmc-phosphor-image

Additional details can be found in the docs repository.

Build Validation and Testing

Commits submitted by members of the OpenBMC GitHub community are compiled and tested via our Jenkins server. Commits are run through two levels of testing. At the repository level the makefile make check directive is run. At the system level, the commit is built into a firmware image and run with an arm-softmmu QEMU model against a barrage of CI tests.

Commits submitted by non-members do not automatically proceed through CI testing. After visual inspection of the commit, a CI run can be manually performed by the reviewer.

Automated testing against the QEMU model along with supported systems are performed. The OpenBMC project uses the Robot Framework for all automation. Our complete test repository can be found here.

Submitting Patches

Support of additional hardware and software packages is always welcome. Please follow the contributing guidelines when making a submission. It is expected that contributions contain test cases.

Bug Reporting

Issues are managed on GitHub. It is recommended you search through the issues before opening a new one.

Features of OpenBMC

Feature List

  • REST Management
  • IPMI
  • SSH based SOL
  • Power and Cooling Management
  • Event Logs
  • Zeroconf discoverable
  • Sensors
  • Inventory
  • LED Management
  • Host Watchdog
  • Simulation
  • Code Update Support for multiple BMC/BIOS images
  • POWER On Chip Controller (OCC) Support

Features In Progress

  • Full IPMI 2.0 Compliance with DCMI
  • Verified Boot
  • HTML5 Java Script Web User Interface
  • BMC RAS

Features Requested but need help

  • OpenCompute Redfish Compliance
  • OpenBMC performance monitoring
  • cgroup user management and policies
  • Remote KVM
  • Remote USB
  • OpenStack Ironic Integration
  • QEMU enhancements

Finding out more

Dive deeper in to OpenBMC by opening the docs repository.

Contact