| commit | e32dee22a24e910a5fbe704f639451352c0d90c6 | [log] [tgz] |
|---|---|---|
| author | Patrick Williams <patrick@stwcx.xyz> | Mon Aug 26 14:42:52 2024 -0400 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Mon Aug 26 21:45:47 2024 -0400 |
| tree | 73003aee9128769ecee2885246f52e17b9eb6f3b | |
| parent | 5b984e69adad9dfc3b213f4ead1d7f1c4926e10f [diff] |
meta-facebook: harma: move mctp scripts from share to libexec Per anti-patterns document[1], libexec should be used. [1]: https://github.com/openbmc/docs/blob/879601d92becfa1dbc082f487abfb5e0151a5091/anti-patterns.md?plain=1#L225 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I46c375d5ffd4a8bbaf77ec53a6943a8ad0a8651f
diff --git a/meta-facebook/meta-harma/recipes-networking/mctp/files/setup-eid.conf b/meta-facebook/meta-harma/recipes-networking/mctp/files/setup-eid.conf index d936d30..3074382 100644 --- a/meta-facebook/meta-harma/recipes-networking/mctp/files/setup-eid.conf +++ b/meta-facebook/meta-harma/recipes-networking/mctp/files/setup-eid.conf
@@ -3,7 +3,7 @@ Requires=mctpd.service [Service] -ExecStartPre=-/usr/share/mctp/setup-local-eid -ExecStartPost=-/usr/share/mctp/setup-bic-eid +ExecStartPre=-/usr/libexec/mctp/setup-local-eid +ExecStartPost=-/usr/libexec/mctp/setup-bic-eid Restart=always -RestartSec=10 \ No newline at end of file +RestartSec=10
diff --git a/meta-facebook/meta-harma/recipes-networking/mctp/mctp_%.bbappend b/meta-facebook/meta-harma/recipes-networking/mctp/mctp_%.bbappend index 58af028..c33d4da 100644 --- a/meta-facebook/meta-harma/recipes-networking/mctp/mctp_%.bbappend +++ b/meta-facebook/meta-harma/recipes-networking/mctp/mctp_%.bbappend
@@ -13,13 +13,14 @@ do_install:append () { override_dir=${D}${systemd_system_unitdir}/mctpd.service.d install -d ${D}${systemd_system_unitdir}/mctpd.service.d - install -d ${D}${datadir}/mctp install -m 0644 ${WORKDIR}/setup-eid.conf \ ${override_dir}/setup-eid.conf + install -d ${D}${libexecdir}/mctp + install -m 0755 ${WORKDIR}/setup-local-eid \ - ${D}${datadir}/mctp/ + ${D}${libexecdir}/mctp/ install -m 0755 ${WORKDIR}/setup-bic-eid \ - ${D}${datadir}/mctp/ + ${D}${libexecdir}/mctp/ }