systemd: no installation in templated targets
Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).
This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.
Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.
The service files are already properly installed into the appropriate
targets by the recipe.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Idcb5458b6f2a3007c20f546604d4095650148803
diff --git a/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-off@.service b/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-off@.service
index 092409e..c7c44d1 100644
--- a/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-off@.service
+++ b/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-off@.service
@@ -18,4 +18,6 @@
ExecStart=/bin/rm -f /run/openbmc/mpreboot@%i
[Install]
-WantedBy=obmc-host-stop@%i.target
+# Installation of templated services occur in bitbake recipes
+# Leave it commented out here for documentation purposes
+#WantedBy=obmc-host-stop@%i.target
diff --git a/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-on@.service b/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-on@.service
index 8fe7cf7..4458a49 100644
--- a/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-on@.service
+++ b/meta-phosphor/recipes-phosphor/chassis/phosphor-skeleton-control-power/phosphor-wait-power-on@.service
@@ -18,4 +18,6 @@
TimeoutSec=30
[Install]
-WantedBy=obmc-host-start@%i.target
+# Installation of templated services occur in bitbake recipes
+# Leave it commented out here for documentation purposes
+#WantedBy=obmc-host-start@%i.target