commit 60cab57f94a1ceab6e346f9732e939e2866c11f1
author Brandon Kim <brandonkim@google.com> Wed Jun 15 14:20:05 2022 -0700
committer Brandon Kim <brandonkim@google.com> Thu Jun 16 01:39:27 2022 +0000
tree 4cd5a3d3c088b70c6851bd1b6b0223af002318bc
parent 37bc0df170fbd458fe541f8c9a2d8bb67dc412e7

buffer: Update cachedBufferHeader during "initialize"

We know what the bufferheader is after we call "initialize" (as we
clear the buffer before updating the known header). Update
cachedBufferHeader after successful initialization.

Signed-off-by: Brandon Kim <brandonkim@google.com>
Change-Id: Ia4c6f5258b5ccd0294bba267717b8e77c0bf5449

src/buffer.cpp

diff --git a/src/buffer.cpp b/src/buffer.cpp
index a2b8ee4..524984a 100644
--- a/src/buffer.cpp
+++ b/src/buffer.cpp
@@ -60,6 +60,7 @@
             "Buffer initialization buffer header write only wrote '{}'",
             byteWritten));
     }
+    cachedBufferHeader = initializationHeader;
 }
 
 void BufferImpl::readBufferHeader()
@@ -76,7 +77,7 @@
     }
 
     cachedBufferHeader =
-        *reinterpret_cast<CircularBufferHeader*>(bytesRead.data());
+        *reinterpret_cast<struct CircularBufferHeader*>(bytesRead.data());
 };
 
 struct CircularBufferHeader BufferImpl::getCachedBufferHeader() const

test/buffer_test.cpp

diff --git a/test/buffer_test.cpp b/test/buffer_test.cpp
index e3d5621..e8943a9 100644
--- a/test/buffer_test.cpp
+++ b/test/buffer_test.cpp
@@ -78,6 +78,7 @@
             throw;
         },
         std::runtime_error);
+    EXPECT_NE(bufferImpl->getCachedBufferHeader(), testInitializationHeader);
 
     EXPECT_CALL(*dataInterfaceMockPtr, getMemoryRegionSize())
         .WillOnce(Return(testRegionSize));
@@ -97,6 +98,7 @@
             throw;
         },
         std::runtime_error);
+    EXPECT_NE(bufferImpl->getCachedBufferHeader(), testInitializationHeader);
 }
 
 TEST_F(BufferTest, BufferInitializePass)
@@ -117,6 +119,7 @@
     EXPECT_NO_THROW(bufferImpl->initialize(testBmcInterfaceVersion,
                                            testQueueSize, testUeRegionSize,
                                            testMagicNumber));
+    EXPECT_EQ(bufferImpl->getCachedBufferHeader(), testInitializationHeader);
 }
 
 TEST_F(BufferTest, BufferHeaderReadFail)