commit 02cad96e3a83b0c9a01dbc87219c1b8b6681fa67
author Ed Tanous <edtanous@google.com> Thu Jun 30 16:50:15 2022 -0700
committer Ed Tanous <ed@tanous.net> Tue Jul 12 18:38:38 2022 +0000
tree a2dab0f07fe50ed5708f3c6fea43b7d2af5419e7
parent bb60f4ded18153718709e23dc1d648eb2ae13743

Fix const correctness issues

cppcheck correctly notes that a lot of variables in the new code can be
const.  Make most of them const.

Tested: WIP

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8f37b6353fd707923f533e1d61c5b5419282bf23

redfish-core/lib/task.hpp

diff --git a/redfish-core/lib/task.hpp b/redfish-core/lib/task.hpp
index dcad059..8892614 100644
--- a/redfish-core/lib/task.hpp
+++ b/redfish-core/lib/task.hpp
@@ -120,7 +120,7 @@
 
         if (tasks.size() >= maxTaskCount)
         {
-            auto& last = tasks.front();
+            const auto& last = tasks.front();
 
             // destroy all references
             last->timer.cancel();
@@ -389,7 +389,7 @@
             return;
         }
 
-        std::shared_ptr<task::TaskData>& ptr = *find;
+        const std::shared_ptr<task::TaskData>& ptr = *find;
 
         asyncResp->res.jsonValue["@odata.type"] = "#Task.v1_4_3.Task";
         asyncResp->res.jsonValue["Id"] = strParam;