commit 0870f8c7250c84c747f40363fe8cf337cff49549
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Wed Jun 24 00:28:09 2020 +0000
committer AppaRao Puli <apparao.puli@linux.intel.com> Wed Jul 01 17:43:08 2020 +0000
tree 6eddbc2779253043349dcfd38afd89e9c8c337ca
parent 6f115bbbfdf9d45bad404bf88fc4fe2ffa745a9e

network_protocol: Fix for SSH port

Issue: As per the OCP Redfish Profile v1.0 specification, SSH read only
parameter. By default SSH is disable, but ProtocolEnabled and Port
attributes are mandatory to display in Redfish. But Port property is not
displayed in Redfish URI.

Fix: As Port attribute is mandatory for SSH property, initialized with
null.

Tested:
1. Verified redfish validator passed
2. Verified details from Redfish
GET: https://<BMC-IP>/redfish/v1/Managers/bmc/NetworkProtocol
Before:
Response:
  "SSH": {
    "ProtocolEnabled": false
  },

After:
  "SSH": {
    "Port": null,
    "ProtocolEnabled": false
  },

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I203b321c3b41bab2017e7c6b5e55aa3463ea6e83

redfish-core/lib/network_protocol.hpp

diff --git a/redfish-core/lib/network_protocol.hpp b/redfish-core/lib/network_protocol.hpp
index e5448f1..b32fde1 100644
--- a/redfish-core/lib/network_protocol.hpp
+++ b/redfish-core/lib/network_protocol.hpp
@@ -230,6 +230,8 @@
 
         for (auto& protocol : protocolToDBus)
         {
+            asyncResp->res.jsonValue[protocol.first]["Port"] =
+                nlohmann::detail::value_t::null;
             asyncResp->res.jsonValue[protocol.first]["ProtocolEnabled"] = false;
         }