tree bbf15ed94ece3975b7983817016752f3b8967cca
parent e38778a5035eaccf642159c3ef3d70ce837d046a
author Ed Tanous <edtanous@google.com> 1647127855 -0800
committer Ed Tanous <ed@tanous.net> 1661292646 +0000

Remove tcp_stream

tcp_stream has several problems in its current implementation.  First,
it takes up a significant amount of binary size, for features that we
don't use.  Next, it has some implied guarantees about timeouts that we
erronously rely on, namely that async_connect will timeout
appropriately given the tcp_stream timeout (it doesn't).

We already have a timer present in the ConnectionInfo class anyway, this
commit just makes use of it for ALL timeout operations, rather than just
the connect timeout operations.  This flow is roughly analogous to what
we do in http_connection.hpp already, so the pattern is well troden.

This saves 2.8% of the binary size of bmcweb, and solves several race
conditions.


Tested:
Relying on Carson: Aggregated a sub-bmc, and ensured that top level
collections returned correctly under GET /redfish/v1/Chassis

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I72e8e97b667826f272bb4921afc2b16907f3b271