commit 0f83707d6f05640eeff012500ebe66a1b8020df5
author Ed Tanous <edtanous@google.com> Fri Jun 30 09:57:26 2023 -0700
committer Ed Tanous <ed@tanous.net> Mon Jul 10 21:03:22 2023 +0000
tree 17f04867d57dbf0c64c2e70f659bc55ab6a86e5b
parent d5736ef260c5534fb2fe2ee895d62e91bc9319c3

Implement data pointer clang-tidy check

readability-container-data-pointer flags one error in our codebase, but
can definitely find issues in patchsets.  Fix the one error (that came
from crow), and enable the check.

Change-Id: I3045ec9a58d80300c90921dda1a2fe3859ffed7b
Signed-off-by: Ed Tanous <edtanous@google.com>

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index 32f7f75..308c3f9 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -280,6 +280,7 @@
 readability-avoid-const-params-in-decls,
 readability-braces-around-statements,
 readability-const-return-type,
+readability-container-data-pointer,
 readability-container-size-empty,
 readability-convert-member-functions-to-static,
 readability-delete-null-pointer,

http/http_server.hpp

diff --git a/http/http_server.hpp b/http/http_server.hpp
index 258193a..91de8db 100644
--- a/http/http_server.hpp
+++ b/http/http_server.hpp
@@ -67,7 +67,7 @@
         gmtime_r(&lastTimeT, &myTm);
 
         dateStr.resize(100);
-        size_t dateStrSz = strftime(&dateStr[0], 99,
+        size_t dateStrSz = strftime(dateStr.data(), dateStr.size() - 1,
                                     "%a, %d %b %Y %H:%M:%S GMT", &myTm);
         dateStr.resize(dateStrSz);
     }