tree f38c1ee00bf361251b3fbed8259b0a7acc7cff70
parent fd06b304a7bdfb31e61b72376f2150b2a6e062f4
author Gayathri Leburu <gayathri.leburu@intel.com> 1668660715 +0000
committer Ed Tanous <ed@tanous.net> 1670883766 +0000

Fix for incorrect Task Progress and State values

While performing the firmware updates, task will be created for tracking
the background update progress and state. There are error associated
with that code currently.

Errors on TaskId's:
 - Internal errors
     "Messages": [
      ....
      {
        "@odata.type": "#Message.v1_1_1.Message",
        "Message": "The request failed due to an internal service error.  The service is still operational.",
      ....
      }
     ]

 - Always task is in RUNNING state.
     "PercentComplete": 0,
     "TaskState": "Running",

Issue details:
 - Percentage: The "Progress" property in D-Bus interface
   "xyz.openbmc_project.Software.ActivationProgress" is of type
   "uint8_t" but bmcweb is reading type as string and that is leading to
   failure and invalid values.

 - TaskState: TaskState is read from d-bus after recieving associated
   signal but that is not updated properly and that caused the failure.
   this commit corrects the same.

Tested:
 After fix, task which is created for firmware update is showing correct
 "PercentageComplete" and 'TaskState".

  "PercentComplete": 100,
  "TaskState": "Completed",

Signed-off-by: Gayathri Leburu <gayathri.leburu@intel.com>
Signed-off-by: moni kumar <monix.kumar@intel.com>
Signed-off-by: AppaRao Puli <apparao.puli@intel.com>
Change-Id: I0354cdecc9d9ddd47b017591402fd7b3149d12ca