commit 12a002d9ac581b446020050ae9ad6d539cf4f542
author Ed Tanous <ed.tanous@intel.com> Mon May 15 11:59:16 2017 -0700
committer Ed Tanous <ed.tanous@intel.com> Mon May 15 11:59:16 2017 -0700
tree 476f17d116baf35d8769634af58693d07eb395b6
parent 6f01b2c3a5d14d06dc69980643c9c4c0eac862de

Fix narrowing conversion warning on certain compilers

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fe0ce95..013fa7f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -161,10 +161,12 @@
 
 set_source_files_properties(${GENERATED_SRC_FILES} PROPERTIES GENERATED TRUE)
 
+# the webassets file has a non-ideal beahvior, where it loads binary data into a std::string
+# due to the way crow is constructed.  This causes GCC warnings.  Filter them out.
 if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-    if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
+    if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.9)
         set_source_files_properties(${CMAKE_BINARY_DIR}/generated/webassets.cpp PROPERTIES COMPILE_FLAGS -Wno-narrowing)
-    endif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
+    endif(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.9)
 endif()
 
 
@@ -229,6 +231,7 @@
 target_link_libraries(bmcweb ${ZLIB_LIBRARIES})
 add_dependencies(bmcweb packagestaticcpp)
 target_link_libraries(bmcweb  ${DBUS_LIBRARIES})
+install (TARGETS bmcweb DESTINATION bin)
 
 # dbus
 add_executable(dbus_test src/dbus_main.cpp)