commit 17a897df9fd974e7b7b15fe61c9e59179c7b9fca
author Manojkiran Eda <manojkiran.eda@gmail.com> Sat Sep 12 15:31:58 2020 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Mon Nov 02 03:41:47 2020 +0000
tree 0de904ff7e3fd39e883e19e651bc163f0dd5eac2
parent 313efb1c9afcb0192585579a663467c28f873286

Improve loops & fix cpp check warning

- This commit improves certain while loops to range based for loops.

- This commit also fixes the cppcheck warning that mentions about
  performance issues when using postfix operators on non-primitive
  types.

Tested By:
- A function is unittested.
- GET on both EthernetInterfaces & certificate service
  looks good without any issues.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I85420f7bf9af45a97e1a93b916f292c2516f5802

redfish-core/lib/managers.hpp

diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp
index 26c2125..c621de3 100644
--- a/redfish-core/lib/managers.hpp
+++ b/redfish-core/lib/managers.hpp
@@ -1520,7 +1520,7 @@
             std::string& type = containerPair.first;
 
             for (nlohmann::json::iterator it = container->begin();
-                 it != container->end(); it++)
+                 it != container->end(); ++it)
             {
                 const auto& name = it.key();
                 BMCWEB_LOG_DEBUG << "looking for " << name;