commit 1917ee95a4c3a430f2f7afc85d9385d098af3e23
author Ed Tanous <edtanous@google.com> Thu Jun 30 22:30:50 2022 -0700
committer Ed Tanous <ed@tanous.net> Wed Dec 21 21:04:50 2022 +0000
tree 8e113ad6b76f74c5b6cdc7716b9c8af2104d571d
parent 262f115299479c8f1142954622a358d53318e9fd

Avoid copy

cppcheck warns that this is a copy, so fix it.

Tested: cppcheck no longer warns on this line.  Unfortunately, virtual
media does not have a backend, so this is dead code.  No way to test at
this point.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1e98ca63ee346ad683844e5637a173f64286102a

redfish-core/lib/virtual_media.hpp

diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp
index 402cbbd..f287cb2 100644
--- a/redfish-core/lib/virtual_media.hpp
+++ b/redfish-core/lib/virtual_media.hpp
@@ -561,7 +561,7 @@
         return credentials.password();
     }
 
-    SecureBuffer pack(FormatterFunc formatter)
+    SecureBuffer pack(FormatterFunc* formatter)
     {
         SecureBuffer packed{new Buffer{}};
         if (formatter != nullptr)