tree 307d164dc027656482a3dbb19e62715718d3386f
parent 30f11eb44c906c59401a3532e1d4094318e00e02
author Nan Zhou <nanzhoumails@gmail.com> 1653672184 +0000
committer Nan Zhou <nanzhoumails@gmail.com> 1653674512 +0000

memory: set @odata attributes only if the object is found

The existing code returns a JSON payload with @odata attributes even if
it is a 404 not found.

This commit corrects that by moving @odata after the object is found.

Tested:
1. before
```
{
    "@odata.id": "/redfish/v1/Systems/system/Memory/dimm5",
    "@odata.type": "#Memory.v1_11_0.Memory",
    "error": {
        "@Message.ExtendedInfo": [
            {
                "@odata.type": "#Message.v1_1_1.Message",
                "Message": "The requested resource of type Memory named 'dimm5' was not found.",
                "MessageArgs": [
                    "Memory",
                    "dimm5"
                ],
                "MessageId": "Base.1.11.0.ResourceNotFound",
                "MessageSeverity": "Critical",
                "Resolution": "Provide a valid resource identifier and resubmit the request."
            }
        ],
        "code": "Base.1.11.0.ResourceNotFound",
        "message": "The requested resource of type Memory named 'dimm5' was not found."
    }
}
```
after
```
{
    "error": {
        "@Message.ExtendedInfo": [
            {
                "@odata.type": "#Message.v1_1_1.Message",
                "Message": "The requested resource of type Memory named 'dimm5' was not found.",
                "MessageArgs": [
                    "Memory",
                    "dimm5"
                ],
                "MessageId": "Base.1.11.0.ResourceNotFound",
                "MessageSeverity": "Critical",
                "Resolution": "Provide a valid resource identifier and resubmit the request."
            }
        ],
        "code": "Base.1.11.0.ResourceNotFound",
        "message": "The requested resource of type Memory named 'dimm5' was not found."
    }
}
```
2. Service Validator on MemoryResource passes.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Id0f912015b0ecf25cacb22e919ebe88708187677