commit 1c801e1f839e47163e7917e55f5dec3c24485c56
author Andrew Geissler <geissonator@yahoo.com> Fri Oct 08 14:36:01 2021 -0500
committer Ed Tanous <ed@tanous.net> Tue Nov 16 20:36:44 2021 +0000
tree 87c662fb280bb34e8464c1f5a15d51c45c756a4f
parent 9062d478d4dc89598e215e1538ba8fbb8db2cf10

reduce error traces in connection and auth code

These logs are reported in good paths (at least web interfaces are
working fine when they are logged). Convert them to warnings so they do
not show up as false errors when debugging bmcweb.

Here's the log we were getting:
Oct 08 19:20:48 p10bmc bmcweb[15348]: (2021-10-08 19:20:48) [ERROR "http_connection.hpp":537] 0x14bd360 Error while reading: end of stream
Oct 08 19:20:48 p10bmc bmcweb[15348]: (2021-10-08 19:20:48) [ERROR "http_connection.hpp":531] 0x14910b0 async_read_header 308 Bytes
Oct 08 19:20:48 p10bmc bmcweb[15348]: (2021-10-08 19:20:48) [ERROR "authorization.hpp":292] authHeader=

These code paths, and why they are not real errors, is not totally clear
to me. Hoping for some discussion on it in this review.

Tested:
- Verified these no longer show up when doing basic system management
  with just error traces enabled in bmcweb

Change-Id: If357aeb93ff28ef02e135a888524e057cb188871
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

http/http_connection.hpp

diff --git a/http/http_connection.hpp b/http/http_connection.hpp
index b169309..4b4310f 100644
--- a/http/http_connection.hpp
+++ b/http/http_connection.hpp
@@ -529,14 +529,22 @@
             [this,
              self(shared_from_this())](const boost::system::error_code& ec,
                                        std::size_t bytesTransferred) {
-                BMCWEB_LOG_ERROR << this << " async_read_header "
+                BMCWEB_LOG_DEBUG << this << " async_read_header "
                                  << bytesTransferred << " Bytes";
                 bool errorWhileReading = false;
                 if (ec)
                 {
                     errorWhileReading = true;
-                    BMCWEB_LOG_ERROR
-                        << this << " Error while reading: " << ec.message();
+                    if (ec == boost::asio::error::eof)
+                    {
+                        BMCWEB_LOG_WARNING
+                            << this << " Error while reading: " << ec.message();
+                    }
+                    else
+                    {
+                        BMCWEB_LOG_ERROR
+                            << this << " Error while reading: " << ec.message();
+                    }
                 }
                 else
                 {

include/authorization.hpp

diff --git a/include/authorization.hpp b/include/authorization.hpp
index 4869554..40a6119 100644
--- a/include/authorization.hpp
+++ b/include/authorization.hpp
@@ -285,7 +285,7 @@
     }
 #endif
     std::string_view authHeader = reqHeader["Authorization"];
-    BMCWEB_LOG_ERROR << "authHeader=" << authHeader;
+    BMCWEB_LOG_DEBUG << "authHeader=" << authHeader;
 
     if (sessionOut == nullptr && authMethodsConfig.sessionToken)
     {