commit 1c8252799b1c97fad5b05c5746ec512292a1f66c
author Jiaqing Zhao <jiaqing.zhao@intel.com> Mon Mar 28 15:17:30 2022 +0800
committer Ed Tanous <ed@tanous.net> Mon Mar 28 18:37:24 2022 +0000
tree ec21b5dbdced38427cfc6627086225a67824563e
parent 313c1b76d9ad3f36de2be04387934d45b75d85dd

Drop unused App.sslFile() method

App.sslFile() method is never called, the sslContext is generated in
ensuressl::getSslContext() function now. So remove these unused code.

Tested:
Build pass.

Change-Id: I2737462a3a2ec2e0dc792e5070e9e5a7244bc889
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>

http/app.hpp

diff --git a/http/app.hpp b/http/app.hpp
index c1472e5..59aca39 100644
--- a/http/app.hpp
+++ b/http/app.hpp
@@ -151,35 +151,6 @@
     }
 
 #ifdef BMCWEB_ENABLE_SSL
-    App& sslFile(const std::string& crtFilename, const std::string& keyFilename)
-    {
-        sslContext = std::make_shared<ssl_context_t>(
-            boost::asio::ssl::context::tls_server);
-        sslContext->set_verify_mode(boost::asio::ssl::verify_peer);
-        sslContext->use_certificate_file(crtFilename, ssl_context_t::pem);
-        sslContext->use_private_key_file(keyFilename, ssl_context_t::pem);
-        sslContext->set_options(boost::asio::ssl::context::default_workarounds |
-                                boost::asio::ssl::context::no_sslv2 |
-                                boost::asio::ssl::context::no_sslv3 |
-                                boost::asio::ssl::context::no_tlsv1 |
-                                boost::asio::ssl::context::no_tlsv1_1);
-        return *this;
-    }
-
-    App& sslFile(const std::string& pemFilename)
-    {
-        sslContext = std::make_shared<ssl_context_t>(
-            boost::asio::ssl::context::tls_server);
-        sslContext->set_verify_mode(boost::asio::ssl::verify_peer);
-        sslContext->load_verify_file(pemFilename);
-        sslContext->set_options(boost::asio::ssl::context::default_workarounds |
-                                boost::asio::ssl::context::no_sslv2 |
-                                boost::asio::ssl::context::no_sslv3 |
-                                boost::asio::ssl::context::no_tlsv1 |
-                                boost::asio::ssl::context::no_tlsv1_1);
-        return *this;
-    }
-
     App& ssl(std::shared_ptr<boost::asio::ssl::context>&& ctx)
     {
         sslContext = std::move(ctx);
@@ -191,18 +162,6 @@
     std::shared_ptr<ssl_context_t> sslContext = nullptr;
 
 #else
-    template <typename T, typename... Remain>
-    App& ssl_file(T&&, Remain&&...)
-    {
-        // We can't call .ssl() member function unless BMCWEB_ENABLE_SSL is
-        // defined.
-        static_assert(
-            // make static_assert dependent to T; always false
-            std::is_base_of<T, void>::value,
-            "Define BMCWEB_ENABLE_SSL to enable ssl support.");
-        return *this;
-    }
-
     template <typename T>
     App& ssl(T&&)
     {