commit 247ae89bc26024d335f1317566bebeee52c75089
author Ed Tanous <etanous@nvidia.com> Wed Aug 21 07:57:40 2024 -0700
committer Ed Tanous <ed@tanous.net> Fri Aug 23 23:23:17 2024 +0000
tree 3293f7eeb8868169d4bf2c8ada8749fa031e626a
parent bd1299b74c25fa6123cab497d4b8370689a7a999

Make PATCH return 204 again

It was correctly pointed out that for PATCH, we cannot return 200
success without also returning the object, per Redfish.  This commit
partially reverts cdf25ff, to give PATCH the old (204) behavior again.

Tested: Patch now returns 204

Change-Id: I8ede932a73ae064586d94c47393e4418350adb00
Signed-off-by: Ed Tanous <etanous@nvidia.com>

redfish-core/src/utils/dbus_utils.cpp

diff --git a/redfish-core/src/utils/dbus_utils.cpp b/redfish-core/src/utils/dbus_utils.cpp
index 18535bc..3fe2fb4 100644
--- a/redfish-core/src/utils/dbus_utils.cpp
+++ b/redfish-core/src/utils/dbus_utils.cpp
@@ -82,10 +82,10 @@
         messages::internalError(asyncResp->res);
         return;
     }
-    // Only set success if another error hasn't already happened.
+    // Only set 204 if another error hasn't already happened.
     if (asyncResp->res.result() == boost::beast::http::status::ok)
     {
-        messages::success(asyncResp->res);
+        asyncResp->res.result(boost::beast::http::status::no_content);
     }
 };
 

test/redfish-core/include/utils/dbus_utils.cpp

diff --git a/test/redfish-core/include/utils/dbus_utils.cpp b/test/redfish-core/include/utils/dbus_utils.cpp
index bcd37da..c768f92 100644
--- a/test/redfish-core/include/utils/dbus_utils.cpp
+++ b/test/redfish-core/include/utils/dbus_utils.cpp
@@ -29,6 +29,19 @@
     afterSetProperty(asyncResp, "MyRedfishProperty",
                      nlohmann::json("MyRedfishValue"), ec, msg);
 
+    EXPECT_EQ(asyncResp->res.result(), boost::beast::http::status::no_content);
+}
+
+TEST(DbusUtils, AfterActionPropertySetSuccess)
+{
+    std::shared_ptr<bmcweb::AsyncResp> asyncResp =
+        std::make_shared<bmcweb::AsyncResp>();
+
+    boost::system::error_code ec;
+    sdbusplus::message_t msg;
+    afterSetPropertyAction(asyncResp, "MyRedfishProperty",
+                           nlohmann::json("MyRedfishValue"), ec, msg);
+
     EXPECT_EQ(asyncResp->res.result(), boost::beast::http::status::ok);
     EXPECT_EQ(asyncResp->res.jsonValue,
               R"({