tree 9ea535360f1e80603fcb599013f42263846e700d
parent f94c4ecf9cf61b91b552731e4e03cd84c1070972
author Ed Tanous <edtanous@google.com> 1641501954 -0800
committer Ed Tanous <ed@tanous.net> 1642012334 +0000

enable bugprone exception escape check

clang-13 includes new checks, and finds some issues.  The first is that
the boost::vector constructor can possibly throw, so replace the
underlying flat_map container with std::vector instead.

The others are places where we could possibly throw in destructors,
which would be bad.  Ideally we wouldn't use the destructor pattern, but
that would be non-trivial to clean up at this point, so just catch the
exception, and log it.  At the same time, catch exceptions thrown to
main and log them.

Tested: Code compiles

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I77b86eaa2fc79e43d1ca044c78ca3b0ce0a7c38c