Increase TFTP timeout
IBM, the only user of TFTP, has a system with 200MB images.
https://github.com/openbmc/openbmc/blob/master/meta-ibm/recipes-phosphor/bmcweb/bmcweb_%25.bbappend#L2
In the future this system's images might grow even larger.
Currently timed the TFTP transfer time at 2 min 37 sec on this system.
Bumped to 10 min though for room for the image to grow and pad the
timeout in case an even slower network.
Considered a parameter, can add if it would ever get set to a different
value.
Tested: TFTP update from GUI works with
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/35738
Change-Id: I1eed110c9605ee1e116670e46f561c66676e5eed
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/redfish-core/lib/update_service.hpp b/redfish-core/lib/update_service.hpp
index a0fd252..2aedf85 100644
--- a/redfish-core/lib/update_service.hpp
+++ b/redfish-core/lib/update_service.hpp
@@ -468,13 +468,13 @@
BMCWEB_LOG_DEBUG << "Server: " << tftpServer + " File: " << fwFile;
// Setup callback for when new software detected
- // Give TFTP 2 minutes to complete
+ // Give TFTP 10 minutes to complete
monitorForSoftwareAvailable(
nullptr, req,
"/redfish/v1/UpdateService/Actions/UpdateService.SimpleUpdate",
- 120);
+ 600);
- // TFTP can take up to 2 minutes depending on image size and
+ // TFTP can take up to 10 minutes depending on image size and
// connection speed. Return to caller as soon as the TFTP operation
// has been started. The callback above will ensure the activate
// is started once the download has completed