| commit | 26ccae32112679c4653c1e3f8a1203c828bea05c | [log] [tgz] |
|---|---|---|
| author | Ed Tanous <edtanous@google.com> | Thu Feb 16 10:28:44 2023 -0800 |
| committer | Ed Tanous <ed@tanous.net> | Fri Feb 24 17:21:14 2023 +0000 |
| tree | a87d5056294e163b9ddeed9e867bcfb0750a8bb5 | |
| parent | 7da1c58890e82194ff83ca6c8d55b5c327f2444a [diff] [blame] |
Pass string views by value string_view should always be passed by value; This commit is a sed replace of the code to make all string_views pass by value, per general coding guidelines[1]. [1] https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/ Tested: Code compiles. Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: I55b342a29a0fbfce0a4ed9ea63db6014d03b134c
diff --git a/include/human_sort.hpp b/include/human_sort.hpp index f4dfbe0..7ab326d 100644 --- a/include/human_sort.hpp +++ b/include/human_sort.hpp
@@ -22,8 +22,7 @@ } // namespace details -inline int alphanumComp(const std::string_view left, - const std::string_view right) +inline int alphanumComp(std::string_view left, std::string_view right) { std::string_view::const_iterator l = left.begin();