Fix a bunch of warnings
using the list of warnings from here:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Seems like a good place to start, and would improve things a bit
type-wise. This patchset attempts to correct all the issues in one
shot.
Tested:
It builds. Will test various subsystems that have been touched
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e
diff --git a/include/obmc_console.hpp b/include/obmc_console.hpp
index ca723d3..25f3b39 100644
--- a/include/obmc_console.hpp
+++ b/include/obmc_console.hpp
@@ -44,7 +44,7 @@
if (ec == boost::asio::error::eof)
{
- for (auto session : sessions)
+ for (crow::websocket::Connection* session : sessions)
{
session->close("Error in reading to host port");
}
@@ -70,14 +70,14 @@
{
BMCWEB_LOG_ERROR << "Couldn't read from host serial port: "
<< ec;
- for (auto session : sessions)
+ for (crow::websocket::Connection* session : sessions)
{
session->close("Error in connecting to host port");
}
return;
}
std::string_view payload(outputBuffer.data(), bytesRead);
- for (auto session : sessions)
+ for (crow::websocket::Connection* session : sessions)
{
session->sendBinary(payload);
}
@@ -90,7 +90,7 @@
if (ec)
{
BMCWEB_LOG_ERROR << "Couldn't connect to host serial port: " << ec;
- for (auto session : sessions)
+ for (crow::websocket::Connection* session : sessions)
{
session->close("Error in connecting to host port");
}