| commit | 271584ab78b4c1926f766aa26ddfde7da329059f | [log] [tgz] |
|---|---|---|
| author | Ed Tanous <ed.tanous@intel.com> | Tue Jul 09 16:24:22 2019 -0700 |
| committer | Ed Tanous <ed.tanous@intel.com> | Thu Oct 10 23:25:26 2019 +0000 |
| tree | 08001912ea542de88b9c31f5d53f195dedd56988 | |
| parent | 70ee8cbd4f3ec5b3e3c18967de221a9f3a70cd38 [diff] [blame] |
Fix a bunch of warnings using the list of warnings from here: https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100 Seems like a good place to start, and would improve things a bit type-wise. This patchset attempts to correct all the issues in one shot. Tested: It builds. Will test various subsystems that have been touched Signed-off-by: Ed Tanous <ed.tanous@intel.com> Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e
diff --git a/include/persistent_data_middleware.hpp b/include/persistent_data_middleware.hpp index 1162fc5..5d7e97c 100644 --- a/include/persistent_data_middleware.hpp +++ b/include/persistent_data_middleware.hpp
@@ -25,7 +25,7 @@ class Middleware { - int jsonRevision = 1; + uint64_t jsonRevision = 1; public: // todo(ed) should read this from a fixed location somewhere, not CWD @@ -62,7 +62,7 @@ void readData() { std::ifstream persistentFile(filename); - int fileRevision = 0; + uint64_t fileRevision = 0; if (persistentFile.is_open()) { // call with exceptions disabled