Fix a bunch of warnings
using the list of warnings from here:
https://github.com/lefticus/cppbestpractices/blob/e73393f25a85f83fed7399d8b65cb117d00b2231/02-Use_the_Tools_Available.md#L100
Seems like a good place to start, and would improve things a bit
type-wise. This patchset attempts to correct all the issues in one
shot.
Tested:
It builds. Will test various subsystems that have been touched
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
Change-Id: I588c26440e5a97f718a0f0ea74cc84107d53aa1e
diff --git a/redfish-core/lib/account_service.hpp b/redfish-core/lib/account_service.hpp
index 9dac7e4..a183f68 100644
--- a/redfish-core/lib/account_service.hpp
+++ b/redfish-core/lib/account_service.hpp
@@ -299,7 +299,7 @@
<< ",LocalRole=" << *localRole;
crow::connections::systemBus->async_method_call(
- [asyncResp, serverType, index, localRole,
+ [asyncResp, serverType, localRole,
remoteGroup](const boost::system::error_code ec) {
if (ec)
{
@@ -422,43 +422,43 @@
for (const auto& property : interface.second)
{
- const std::string* value =
+ const std::string* strValue =
std::get_if<std::string>(
&property.second);
- if (value == nullptr)
+ if (strValue == nullptr)
{
continue;
}
if (property.first == "LDAPServerURI")
{
- confData.uri = *value;
+ confData.uri = *strValue;
}
else if (property.first == "LDAPBindDN")
{
- confData.bindDN = *value;
+ confData.bindDN = *strValue;
}
else if (property.first == "LDAPBaseDN")
{
- confData.baseDN = *value;
+ confData.baseDN = *strValue;
}
else if (property.first ==
"LDAPSearchScope")
{
- confData.searchScope = *value;
+ confData.searchScope = *strValue;
}
else if (property.first ==
"GroupNameAttribute")
{
- confData.groupAttribute = *value;
+ confData.groupAttribute = *strValue;
}
else if (property.first ==
"UserNameAttribute")
{
- confData.userNameAttribute = *value;
+ confData.userNameAttribute = *strValue;
}
else if (property.first == "LDAPType")
{
- confData.serverType = *value;
+ confData.serverType = *strValue;
}
}
}
@@ -469,22 +469,22 @@
LDAPRoleMapData roleMapData{};
for (const auto& property : interface.second)
{
- const std::string* value =
+ const std::string* strValue =
std::get_if<std::string>(
&property.second);
- if (value == nullptr)
+ if (strValue == nullptr)
{
continue;
}
if (property.first == "GroupName")
{
- roleMapData.groupName = *value;
+ roleMapData.groupName = *strValue;
}
else if (property.first == "Privilege")
{
- roleMapData.privilege = *value;
+ roleMapData.privilege = *strValue;
}
}
@@ -1518,7 +1518,7 @@
crow::connections::systemBus->async_method_call(
[this, asyncResp, username, password(std::move(password)),
roleId(std::move(roleId)), enabled(std::move(enabled)),
- newUser{std::string(*newUserName)}, locked(std::move(locked))](
+ newUser{*newUserName}, locked(std::move(locked))](
const boost::system::error_code ec) {
if (ec)
{