Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / bmcweb / 286b9118a35ba8c212972b9c30a257ee41c5d7d2
commit286b9118a35ba8c212972b9c30a257ee41c5d7d2[log] [tgz]
authorJohnathan Mantey <johnathanx.mantey@intel.com>Mon Jun 10 13:38:04 2019 -0700
committerJohnathan Mantey <johnathanx.mantey@intel.com>Thu Jun 13 10:54:16 2019 -0700
tree0492ee7f9df392cbaa44c96d2dff7e3c0fc45317
parent7e27d832812fa32630a805c7fd752ec5ed80d28e [diff]
Redfish: Remove "state" response content from PATCH commands

A PATCH command should not return any JSON content for the NICs. PATCH
commands should only return success or failure responses.

Reporting state based upon the input to the command is, in most
instances, going to be incorrect in comparison to the actual state of
the HW.  For example: moving from static addresses to a DHCP assigned
address cannot be predicted based upon the input. It also takes
several seconds for a DHCP transaction to complete, which creates a
significant temporal lag between what was sent and what will be.

Tested: Performed the following tests:

For IPv4:
         "IPv4Addresses": [
             {},
             {
                "Address": "192.168.20.12",
                "SubnetMask": "255.255.255.0",
                "Gateway": "192.168.20.1"
             }
         ]
For IPv6:
         "IPv6StaticAddresses": [
             {
                 "Address": "2001::5:4:3:4",
                 "PrefixLength": 64
             }
         ]

Both tests complete without emitting any JSON content.

Change-Id: Ic7eb824eb6d996d85d52a3b7c855e9825f4a0d87
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
1 file changed
tree: 0492ee7f9df392cbaa44c96d2dff7e3c0fc45317
  1. cmake/
  2. crow/
  3. include/
  4. redfish-core/
  5. scripts/
  6. src/
  7. static/
  8. .clang-format
  9. .clang-tidy
  10. .gitignore
  11. aspeed_purley.cmake
  12. bmcweb.service.in
  13. bmcweb.socket
  14. build_x86.sh
  15. cmake-format.json
  16. CMakeLists.txt
  17. CMakeLists.txt.in
  18. DEVELOPING.md
  19. JenkinsFile
  20. LICENCE
  21. MAINTAINERS
  22. pam-webserver
  23. README.md
README.md

OpenBMC webserver

This component attempts to be a "do everything" embedded webserver for openbmc.

Capabilities

At this time, the webserver implements a few interfaces:

  • Authentication middleware that supports cookie and token based authentication, as well as CSRF prevention backed by linux PAM authentication credentials.
  • An (incomplete) attempt at replicating phosphor-dbus-rest interfaces in C++. Right now, a few of the endpoint definitions work as expected, but there is still a lot of work to be done. The portions of the interface that are functional are designed to work correctly for phosphor-webui, but may not yet be complete.
  • Replication of the rest-dbus backend interfaces to allow bmc debug to logged in users.
  • An initial attempt at a read-only redfish interface. Currently the redfish interface targets ServiceRoot, SessionService, AccountService, Roles, and ManagersService. Some functionality here has been shimmed to make development possible. For example, there exists only a single user role.
  • SSL key generation at runtime. See the configuration section for details.
  • Static file hosting. Currently, static files are hosted from the fixed location at /usr/share/www. This is intended to allow loose coupling with yocto projects, and allow overriding static files at build time.
  • Dbus-monitor over websocket. A generic endpoint that allows UIs to open a websocket and register for notification of events to avoid polling in single page applications. (this interface may be modified in the future due to security concerns.

Configuration

BMCWeb is configured by setting -D flags that correspond to options in bmcweb/CMakeLists.txt and then compiling. For example, cmake -DBMCWEB_ENABLE_KVM=NO ... followed by make. The option names become C++ preprocessor symbols that control which code is compiled into the program.

When BMCWeb starts running, it reads persistent configuration data (such as UUID and session data) from a local file. If this is not usable, it generates a new configuration.

When BMCWeb SSL support is enabled and a usable certificate is not found, it will generate a self-sign a certificate before launching the server. The keys are generated by the prime256v1 algorithm. The certificate

  • is issued by C=US, O=OpenBMC, CN=testhost,
  • is valid for 10 years,
  • has a random serial number, and
  • is signed using the SHA-256 algorithm.

Crow patches

The crow project has had a number of additions to make it more useful for use in the OpenBmc Project. A non-exhaustive list is below. At the time of this writing, the crow project is not accepting patches, so for the time being crow will simply be checked in as is.

  • Applied clang-format to the whole crow tree. This was done without regard for arrays and fixed data structures, but was deemed to be overall better than the inconsistent formatting that existed in upstream previously.
  • Crow server now calls stop before destruction of the Crow app object.
  • Fixed a bug where timed out websockets would seg fault the system by accessing a destroyed socket object without null checks when in SSL mode.
  • Added a TestSocketAdapter class that could be used to unit test server behavior without utilizing a socket.
  • Added the "getRoutes" call to both the app and the routing Trie class that allows consumers to poll the server for all (or a subset of) registered web routes in the system.
  • Hardcoded the websocket implementation for binary mode, instead of leaving protocol unspecified.
  • Move most uses of std::unordered_map to boost::flat_map to lower memory consumption, and (in some cases) to improve memory locality.
  • Adjust the addHeaders mechanism to use a fixed string instead of a full map implementation to avoid unnecessary mallocs and reduce the number of scatter gather buffers on an http response.
  • Change server name header from Crow/0.1 to iBMC
  • Starts the http server io_context inside the main thread, instead of creating a new thread.
  • Removes all BMCWEB_MSVC_WORKAROUND flags.
  • Removes the behavior that causes a 301 redirect for paths that end in "/", and simply returns the endpoint requested. This was done for redfish compatibility.
  • Removes the built in crow/json.hpp package and adds nlohmann json package as the first class json package for crow.
  • Move uses of boost::array to std::array where possible.
  • Add the ability to get a reference to the crow::Request object on websocket connection to allow checking header values.
  • Patch http handler to call middlewares on websocket connections to allow authentication to be applied appropriately.
  • Adds an is_secure flag to provide information about whether or not the payload was delivered over ssl.