Use human sort for EthernetInterfaces
Much like we've done for the other collections, we should be sorting
these such that humans can use them.
This commit reorders the EthernetInterfacesCollection to report in
numerical order. In redfish, these collections are considered sets, so
therefore order is irrelevant to software, but keeping these things
useful for humans is important, therefore it's a pretty trivial change
to order them in a way that humans expect (1, 2, 3, etc).
Tested:
GET /redfish/v1/Managers/bmc/EthernetInterfaces
Returns interfaces in eth0 then eth1.
Redfish service validator passes.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic48f9be5366afee49fc9fec77a3bb194ab25577d
diff --git a/redfish-core/lib/ethernet.hpp b/redfish-core/lib/ethernet.hpp
index 5c928d6..31a379d 100644
--- a/redfish-core/lib/ethernet.hpp
+++ b/redfish-core/lib/ethernet.hpp
@@ -20,6 +20,7 @@
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "health.hpp"
+#include "human_sort.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "utils/ip_utils.hpp"
@@ -865,6 +866,10 @@
}
}
}
+
+ std::sort(ifaceList.begin(), ifaceList.end(),
+ AlphanumLess<std::string>());
+
// Finally make a callback with useful data
callback(true, ifaceList);
});