commit 2c70f8004afdc27bd42968b8bf7480f2e534974c
author Ed Tanous <ed@tanous.net> Mon Sep 28 14:29:23 2020 -0700
committer Ed Tanous <ed@tanous.net> Tue Sep 29 11:38:42 2020 -0700
tree 569f4cb0110aae2ccd0e4d197efe4c3a36c5b7b6
parent 3e4c7797033926a0502cdd4491421c8b16684aef

Fix naming conventions

Lots of code has been checked in that doesn't match the naming
conventions.  Lets fix that.

Tested:
Code compiles.  Variable/function renames only.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I6bd107811d0b724f1fad990016113cdf035b604b

http/http_connection.h

diff --git a/http/http_connection.h b/http/http_connection.h
index b07459d..3459d55 100644
--- a/http/http_connection.h
+++ b/http/http_connection.h
@@ -74,11 +74,11 @@
         req.emplace(parser->get());
 
 #ifdef BMCWEB_ENABLE_MUTUAL_TLS_AUTHENTICATION
-        auto ca_available = !std::filesystem::is_empty(
+        auto caAvailable = !std::filesystem::is_empty(
             std::filesystem::path(ensuressl::trustStorePath));
-        if (ca_available && persistent_data::SessionStore::getInstance()
-                                .getAuthMethodsConfig()
-                                .tls)
+        if (caAvailable && persistent_data::SessionStore::getInstance()
+                               .getAuthMethodsConfig()
+                               .tls)
         {
             adaptor.set_verify_mode(boost::asio::ssl::verify_peer);
             SSL_set_session_id_context(

http/routing.h

diff --git a/http/routing.h b/http/routing.h
index 1af1b2b..7b9086a 100644
--- a/http/routing.h
+++ b/http/routing.h
@@ -1059,10 +1059,10 @@
         {
             return;
         }
-        for (uint32_t method = 0, method_bit = 1; method < maxHttpVerbCount;
-             method++, method_bit <<= 1)
+        for (uint32_t method = 0, methodBit = 1; method < maxHttpVerbCount;
+             method++, methodBit <<= 1)
         {
-            if (ruleObject->methodsBitfield & method_bit)
+            if (ruleObject->methodsBitfield & methodBit)
             {
                 perMethods[method].rules.emplace_back(ruleObject);
                 perMethods[method].trie.add(

http/utility.h

diff --git a/http/utility.h b/http/utility.h
index ec0a889..862f1db 100644
--- a/http/utility.h
+++ b/http/utility.h
@@ -315,12 +315,12 @@
 {
     template <typename F1, typename... Args1,
               typename = decltype(std::declval<F1>()(std::declval<Args1>()...))>
-    static char __test(int);
+    static char test(int);
 
     template <typename...>
-    static int __test(...);
+    static int test(...);
 
-    static constexpr bool value = sizeof(__test<F, Args...>(0)) == sizeof(char);
+    static constexpr bool value = sizeof(test<F, Args...>(0)) == sizeof(char);
 };
 
 template <uint64_t N>

http/websocket.h

diff --git a/http/websocket.h b/http/websocket.h
index 61b3463..021fffa 100644
--- a/http/websocket.h
+++ b/http/websocket.h
@@ -34,7 +34,7 @@
     virtual void sendText(const std::string_view msg) = 0;
     virtual void sendText(std::string&& msg) = 0;
     virtual void close(const std::string_view msg = "quit") = 0;
-    virtual boost::asio::io_context& get_io_context() = 0;
+    virtual boost::asio::io_context& getIoContext() = 0;
     virtual ~Connection() = default;
 
     void userdata(void* u)
@@ -81,7 +81,7 @@
         BMCWEB_LOG_DEBUG << "Creating new connection " << this;
     }
 
-    boost::asio::io_context& get_io_context() override
+    boost::asio::io_context& getIoContext() override
     {
         return static_cast<boost::asio::io_context&>(
             ws.get_executor().context());