Implement debug logging for responses
In production code, we should never call end() on a response twice. In
practice there are a lot of cases where this happens, and while it's
handled gracefully, it's incorrect. This adds error logging for this
case.
Change-Id: Iffb1dd26bfc656e9ca8cf1f179b90e501f3da949
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
diff --git a/crow/include/crow/http_response.h b/crow/include/crow/http_response.h
index d3fdd03..6c28237 100644
--- a/crow/include/crow/http_response.h
+++ b/crow/include/crow/http_response.h
@@ -92,13 +92,18 @@
}
void end() {
- if (!completed_) {
- completed_ = true;
-
- if (complete_request_handler_) {
- complete_request_handler_();
- }
+ if (completed_) {
+ CROW_LOG_ERROR << "Response was ended twice";
+ return;
}
+ completed_ = true;
+ CROW_LOG_DEBUG << "calling completion handler";
+ if (!complete_request_handler_) {
+ CROW_LOG_ERROR << "completion handler was invalid";
+ return;
+ }
+ complete_request_handler_();
+
}
void end(boost::string_view body_part) {