Write the clang-tidy file OpenBMC needs
Now that CI can handle clang-tidy, and a lot of the individual fixes
have landed for the various static analysis checks, lets see how close
we are.
This includes bringing a bunch of the code up to par with the checks
that require. Most of them fall into the category of extraneous else
statements, const correctness problems, or extra copies.
Tested:
CI only. Unit tests pass.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I9fbd346560a75fdd3901fa40c57932486275e912
diff --git a/http/http_client.hpp b/http/http_client.hpp
index 93c2a60..cc30cab 100644
--- a/http/http_client.hpp
+++ b/http/http_client.hpp
@@ -222,16 +222,13 @@
state = ConnState::terminated;
return;
}
- else if (retryPolicyAction == "SuspendRetries")
+ if (retryPolicyAction == "SuspendRetries")
{
state = ConnState::suspended;
return;
}
- else
- {
- // keep retrying, reset count and continue.
- retryCount = 0;
- }
+ // keep retrying, reset count and continue.
+ retryCount = 0;
}
if ((state == ConnState::connectFailed) ||
@@ -265,11 +262,8 @@
});
return;
}
- else
- {
- // reset retry count.
- retryCount = 0;
- }
+ // reset retry count.
+ retryCount = 0;
connStateCheck();
return;