Write the clang-tidy file OpenBMC needs
Now that CI can handle clang-tidy, and a lot of the individual fixes
have landed for the various static analysis checks, lets see how close
we are.
This includes bringing a bunch of the code up to par with the checks
that require. Most of them fall into the category of extraneous else
statements, const correctness problems, or extra copies.
Tested:
CI only. Unit tests pass.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I9fbd346560a75fdd3901fa40c57932486275e912
diff --git a/include/ssl_key_handler.hpp b/include/ssl_key_handler.hpp
index deb3a76..19d3ec7 100644
--- a/include/ssl_key_handler.hpp
+++ b/include/ssl_key_handler.hpp
@@ -32,10 +32,7 @@
{
return true;
}
- else
- {
- return false;
- }
+ return false;
}
inline bool validateCertificate(X509* const cert)
@@ -85,12 +82,9 @@
<< X509_verify_cert_error_string(errCode);
return true;
}
- else
- {
- BMCWEB_LOG_ERROR << "Certificate verification failed. Reason: "
- << X509_verify_cert_error_string(errCode);
- return false;
- }
+ BMCWEB_LOG_ERROR << "Certificate verification failed. Reason: "
+ << X509_verify_cert_error_string(errCode);
+ return false;
}
BMCWEB_LOG_ERROR