Write the clang-tidy file OpenBMC needs
Now that CI can handle clang-tidy, and a lot of the individual fixes
have landed for the various static analysis checks, lets see how close
we are.
This includes bringing a bunch of the code up to par with the checks
that require. Most of them fall into the category of extraneous else
statements, const correctness problems, or extra copies.
Tested:
CI only. Unit tests pass.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I9fbd346560a75fdd3901fa40c57932486275e912
diff --git a/redfish-core/lib/cpudimm.hpp b/redfish-core/lib/cpudimm.hpp
index e670037..e4b7a9d 100644
--- a/redfish-core/lib/cpudimm.hpp
+++ b/redfish-core/lib/cpudimm.hpp
@@ -103,11 +103,8 @@
// HTTP Code will be set up automatically, just return
return;
}
- else
- {
- aResp->res.jsonValue["Status"]["State"] = "Enabled";
- present = true;
- }
+ aResp->res.jsonValue["Status"]["State"] = "Enabled";
+ present = true;
aResp->res.jsonValue["TotalCores"] = *coresCount;
}
else if (property.first == "Socket")