Write the clang-tidy file OpenBMC needs
Now that CI can handle clang-tidy, and a lot of the individual fixes
have landed for the various static analysis checks, lets see how close
we are.
This includes bringing a bunch of the code up to par with the checks
that require. Most of them fall into the category of extraneous else
statements, const correctness problems, or extra copies.
Tested:
CI only. Unit tests pass.
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I9fbd346560a75fdd3901fa40c57932486275e912
diff --git a/redfish-core/lib/roles.hpp b/redfish-core/lib/roles.hpp
index 610c086..de2e1ff 100644
--- a/redfish-core/lib/roles.hpp
+++ b/redfish-core/lib/roles.hpp
@@ -28,15 +28,15 @@
{
return "Administrator";
}
- else if (priv == "priv-user")
+ if (priv == "priv-user")
{
return "ReadOnly";
}
- else if (priv == "priv-operator")
+ if (priv == "priv-operator")
{
return "Operator";
}
- else if (priv == "priv-noaccess")
+ if (priv == "priv-noaccess")
{
return "NoAccess";
}