Capture int by value in stringValueTooLong
Per the coding standard, we should be capturing this by int, not const
int&.
Tested: There are no uses of stringValueTooLong(), so noop change to
binary.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idfcb05c962e0a0d489db263a6f845bb1789b5842
diff --git a/redfish-core/include/error_messages.hpp b/redfish-core/include/error_messages.hpp
index 7eeeaea..8aa6ba6 100644
--- a/redfish-core/include/error_messages.hpp
+++ b/redfish-core/include/error_messages.hpp
@@ -310,10 +310,9 @@
* @param[in] arg2 Parameter of message that will replace %2 in its body.
*
* @returns Message StringValueTooLong formatted to JSON */
-nlohmann::json stringValueTooLong(const std::string& arg1, const int& arg2);
+nlohmann::json stringValueTooLong(const std::string& arg1, int arg2);
-void stringValueTooLong(crow::Response& res, const std::string& arg1,
- const int& arg2);
+void stringValueTooLong(crow::Response& res, const std::string& arg1, int arg2);
/**
* @brief Formats SessionTerminated message into JSON
diff --git a/redfish-core/src/error_messages.cpp b/redfish-core/src/error_messages.cpp
index 83ebbfe..599eeae 100644
--- a/redfish-core/src/error_messages.cpp
+++ b/redfish-core/src/error_messages.cpp
@@ -696,7 +696,7 @@
* See header file for more information
* @endinternal
*/
-nlohmann::json stringValueTooLong(const std::string& arg1, const int& arg2)
+nlohmann::json stringValueTooLong(const std::string& arg1, int arg2)
{
return nlohmann::json{
{"@odata.type", "#Message.v1_1_1.Message"},
@@ -709,8 +709,7 @@
"Resubmit the request with an appropriate string length."}};
}
-void stringValueTooLong(crow::Response& res, const std::string& arg1,
- const int& arg2)
+void stringValueTooLong(crow::Response& res, const std::string& arg1, int arg2)
{
res.result(boost::beast::http::status::bad_request);
addMessageToErrorJson(res.jsonValue, stringValueTooLong(arg1, arg2));