Allow a lower DeliveryRetryIntervalSeconds
The current DeliveryRetryIntervalSeconds range is 30 - 180 seconds. As
far as I can tell, this is arbitrary. Lower the minimum to 5 seconds so
the client (the IBM management console) can set it to this low. The
current default will still be 30 seconds. The client wanted it this
low because the data might not be correct by the time the event is
retried. 5 seconds is arbitrary, decided on this only based on the
client's request. A lower minimum of like 1 or even 0 is reasonable to
me but going with 5 seconds because that is the request and what has
been tested.
Tested:
Before:
```
curl -k -H "Content-Type: application/json" -X PATCH https://$bmc/redfish/v1/EventService/ -d '{"DeliveryRetryIntervalSeconds": 5}'
{
"error": {
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The value 5 for the query parameter
DeliveryRetryIntervalSeconds is out of range [30-180].",
"MessageArgs": [
"5",
"DeliveryRetryIntervalSeconds",
"[30-180]"
],
"MessageId": "Base.1.8.1.QueryParameterOutOfRange",
...
```
After:
```
curl -v -k -H "Content-Type: application/json" -X PATCH https://$bmc/redfish/v1/EventService/ -d '{"DeliveryRetryIntervalSeconds": 5}'
...
< HTTP/1.1 200 OK
```
We have this patch downstream and have seen retring at 5 secs.
Change-Id: I462569969565bdc97c15cb190ed65201d50abdf0
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
diff --git a/redfish-core/lib/event_service.hpp b/redfish-core/lib/event_service.hpp
index d473c8e..8826409 100644
--- a/redfish-core/lib/event_service.hpp
+++ b/redfish-core/lib/event_service.hpp
@@ -142,12 +142,12 @@
if (retryInterval)
{
- // Supported range [30 - 180]
- if ((*retryInterval < 30) || (*retryInterval > 180))
+ // Supported range [5 - 180]
+ if ((*retryInterval < 5) || (*retryInterval > 180))
{
messages::queryParameterOutOfRange(
asyncResp->res, std::to_string(*retryInterval),
- "DeliveryRetryIntervalSeconds", "[30-180]");
+ "DeliveryRetryIntervalSeconds", "[5-180]");
}
else
{