| commit | 33c027d68e618ebff5ee948cf1af31cde1425758 | [log] [tgz] |
|---|---|---|
| author | Michal Orzel <michalx.orzel@intel.com> | Wed Nov 05 12:17:36 2025 +0100 |
| committer | Ed Tanous <ed@tanous.net> | Mon Nov 17 22:01:14 2025 +0000 |
| tree | 49e993a7f5c6090f8bdcd9f2a405081d0b1b610c | |
| parent | 0ddb8edfb150ddf93b069e655ce3624d1e2fec54 [diff] |
Triggers: Drop support for LogToLogService action As per discussion on Gerrit [1], current backend behavior during processing the `LogToLogService` trigger action doesn't comply with Redfish specification. It has been decided to invalidate it for now, with an option for revisiting in some future. Related changes: phosphor-dbus-interfaces: [2] telemetry: [3] Tested: Verified that trigger with `LogToLogService` action cannot be created. Redfish Validator scan passed. [1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/80653/comments/fb8e05c7_ead780bb [2] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/85268 [3] https://gerrit.openbmc.org/c/openbmc/telemetry/+/85318 Change-Id: Ia292ebf3f69dfdc603f2b784f0a2f01e2d21a8f4 Signed-off-by: Michal Orzel <michalx.orzel@intel.com>
diff --git a/redfish-core/lib/trigger.hpp b/redfish-core/lib/trigger.hpp index 0cad4ae..948597c 100644 --- a/redfish-core/lib/trigger.hpp +++ b/redfish-core/lib/trigger.hpp
@@ -78,11 +78,6 @@ { return triggers::TriggerActionEnum::RedfishEvent; } - if (dbusValue == - "xyz.openbmc_project.Telemetry.Trigger.TriggerAction.LogToJournal") - { - return triggers::TriggerActionEnum::LogToLogService; - } return triggers::TriggerActionEnum::Invalid; } @@ -96,10 +91,6 @@ { return "xyz.openbmc_project.Telemetry.Trigger.TriggerAction.LogToRedfishEventLog"; } - if (redfishValue == "LogToLogService") - { - return "xyz.openbmc_project.Telemetry.Trigger.TriggerAction.LogToJournal"; - } return ""; }