tree 711c7fc1477c830348a6c57b1490cfffedfc01b6
parent 83f984b53eef3277d9d3da292152aec1250f5f4d
author Asmitha Karunanithi <asmitk01@in.ibm.com> 1631031477 -0500
committer Ed Tanous <ed@tanous.net> 1632413344 +0000

Show only "Completed" dump entries in Redfish resp

In the current implementation, the dumps whose status
remain "InProgress" were also displayed when a GET
request on dump entries is fired. That is, when the user
initiates a dump creation, and immediately does a GET on
dump entries, the dump that is now created will also be
displayed with size 0 and an invalid date in the redfish
response as below, until the status becomes "Completed"

{
  "@odata.id": "/redfish/v1/Managers/bmc/LogServices/Dump/Entries/7",
  "@odata.type": "#LogEntry.v1_7_0.LogEntry",
  "AdditionalDataSizeBytes": 0,
  "AdditionalDataURI": "/redfish/v1/Managers/bmc/LogServices/Dump/Entries/7/attachment",
  "Created": "1970-01-01T00:00:00+00:00",
  "DiagnosticDataType": "Manager",
  "EntryType": "Event",
  "Id": "7",
  "Name": "BMC Dump Entry"
}

This commit contains changes that will avoid displaying
the incomplete dumps.

Tested By:

* GET https://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries/12
{
  "error": {
    "@Message.ExtendedInfo": [
      {
        "@odata.type": "#Message.v1_1_1.Message",
        "Message": "The requested resource of type BMC dump named 12 was not found.",
        "MessageArgs": [
          "BMC dump",
          "12"
        ],
        "MessageId": "Base.1.8.1.ResourceNotFound",
        "MessageSeverity": "Critical",
        "Resolution": "Provide a valid resource identifier and resubmit the request."
      }
    ],
    "code": "Base.1.8.1.ResourceNotFound",
    "message": "The requested resource of type BMC dump named 12 was not found."
  }
}

* GET https://${bmc}/redfish/v1/Managers/bmc/LogServices/Dump/Entries/ -- This also
avoids displaying incomplete dump entries.

Redfish Validator passed.

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: Ifc5e1773cde0c4c4288e8ebbcdf87b2ec480af55