Fix includes
Our includes haven't been enforced by tidy in a while. Run the script,
check in the result, minus the false positives.
Change-Id: I6a6da26f5ba5082d9b4aa17cdc9f55ebd8cd41a6
Signed-off-by: Ed Tanous <etanous@nvidia.com>
diff --git a/features/openbmc_rest/image_upload.hpp b/features/openbmc_rest/image_upload.hpp
index f6a0dfc..0aacc47 100644
--- a/features/openbmc_rest/image_upload.hpp
+++ b/features/openbmc_rest/image_upload.hpp
@@ -21,7 +21,6 @@
#include <algorithm>
#include <chrono>
-#include <cstdio>
#include <fstream>
#include <functional>
#include <memory>
diff --git a/http/http2_connection.hpp b/http/http2_connection.hpp
index 4e3da8e..efd9225 100644
--- a/http/http2_connection.hpp
+++ b/http/http2_connection.hpp
@@ -15,6 +15,7 @@
// NOLINTNEXTLINE(misc-include-cleaner)
#include "nghttp2_adapters.hpp"
+#include "sessions.hpp"
#include <nghttp2/nghttp2.h>
#include <unistd.h>
diff --git a/http/http_client.hpp b/http/http_client.hpp
index 21e0909..81922c0 100644
--- a/http/http_client.hpp
+++ b/http/http_client.hpp
@@ -13,7 +13,6 @@
#include "ssl_key_handler.hpp"
#include <openssl/err.h>
-#include <openssl/ssl.h>
#include <openssl/tls1.h>
#include <boost/asio/connect.hpp>
diff --git a/http/mutual_tls.cpp b/http/mutual_tls.cpp
index 3d170a2..b091ed2 100644
--- a/http/mutual_tls.cpp
+++ b/http/mutual_tls.cpp
@@ -2,8 +2,6 @@
// SPDX-FileCopyrightText: Copyright OpenBMC Authors
#include "mutual_tls.hpp"
-#include "bmcweb_config.h"
-
#include "identity.hpp"
#include "mutual_tls_private.hpp"
#include "sessions.hpp"
diff --git a/http/parsing.hpp b/http/parsing.hpp
index b129402..7489c23 100644
--- a/http/parsing.hpp
+++ b/http/parsing.hpp
@@ -11,7 +11,6 @@
#include <boost/beast/http/field.hpp>
#include <nlohmann/json.hpp>
-#include <cctype>
#include <string_view>
enum class JsonParseResult
diff --git a/http/routing.hpp b/http/routing.hpp
index 2bebd47..ed3a4c4 100644
--- a/http/routing.hpp
+++ b/http/routing.hpp
@@ -18,7 +18,6 @@
#include <algorithm>
#include <array>
-#include <cerrno>
#include <cstdint>
#include <cstdlib>
#include <format>
diff --git a/include/credential_pipe.hpp b/include/credential_pipe.hpp
index ec159e6..dc3e490 100644
--- a/include/credential_pipe.hpp
+++ b/include/credential_pipe.hpp
@@ -12,7 +12,6 @@
#include <boost/asio/write.hpp>
#include <array>
-#include <cstring>
#include <string>
#include <utility>
diff --git a/include/file_test_utilities.hpp b/include/file_test_utilities.hpp
index 1d55509..b12fbca 100644
--- a/include/file_test_utilities.hpp
+++ b/include/file_test_utilities.hpp
@@ -3,7 +3,6 @@
#pragma once
#include <unistd.h>
-#include <cstdlib>
#include <filesystem>
#include <string>
#include <string_view>
diff --git a/include/http_utility.hpp b/include/http_utility.hpp
index 9768526..9ea7ca4 100644
--- a/include/http_utility.hpp
+++ b/include/http_utility.hpp
@@ -18,7 +18,6 @@
#include <algorithm>
#include <array>
-#include <cctype>
#include <ranges>
#include <span>
#include <string_view>
diff --git a/include/identity.hpp b/include/identity.hpp
index 6810fcd..dd869c0 100644
--- a/include/identity.hpp
+++ b/include/identity.hpp
@@ -3,7 +3,6 @@
#include <unistd.h>
#include <array>
-#include <climits>
#include <string>
inline std::string getHostName()
diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp
index ebccf2d..31ee12a 100644
--- a/redfish-core/include/event_service_manager.hpp
+++ b/redfish-core/include/event_service_manager.hpp
@@ -30,15 +30,12 @@
#include <cstdint>
#include <cstdlib>
#include <ctime>
-#include <filesystem>
#include <format>
-#include <fstream>
#include <memory>
#include <optional>
#include <random>
#include <string>
#include <string_view>
-#include <system_error>
#include <utility>
#include <vector>
diff --git a/redfish-core/include/sub_route_trie.hpp b/redfish-core/include/sub_route_trie.hpp
index 3071fe7..f930600 100644
--- a/redfish-core/include/sub_route_trie.hpp
+++ b/redfish-core/include/sub_route_trie.hpp
@@ -5,7 +5,6 @@
#include "logging.hpp"
#include "routing/trie.hpp"
-#include <cerrno>
#include <cstdlib>
#include <format>
#include <stdexcept>
diff --git a/redfish-core/include/utils/manager_utils.hpp b/redfish-core/include/utils/manager_utils.hpp
index a58f357..7430fe3 100644
--- a/redfish-core/include/utils/manager_utils.hpp
+++ b/redfish-core/include/utils/manager_utils.hpp
@@ -8,6 +8,7 @@
#include <nlohmann/json.hpp>
+#include <cstddef>
#include <memory>
#include <string_view>
diff --git a/redfish-core/include/utils/systems_utils.hpp b/redfish-core/include/utils/systems_utils.hpp
index 97afc0c..8e522a0 100644
--- a/redfish-core/include/utils/systems_utils.hpp
+++ b/redfish-core/include/utils/systems_utils.hpp
@@ -5,15 +5,12 @@
#include "bmcweb_config.h"
#include "async_resp.hpp"
-#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "human_sort.hpp"
#include "logging.hpp"
-#include "utility.hpp"
#include <boost/url/format.hpp>
-#include <boost/url/url.hpp>
#include <sdbusplus/message/native_types.hpp>
#include <algorithm>
diff --git a/redfish-core/lib/event_service.hpp b/redfish-core/lib/event_service.hpp
index a9093b3..eb02ab8 100644
--- a/redfish-core/lib/event_service.hpp
+++ b/redfish-core/lib/event_service.hpp
@@ -22,7 +22,6 @@
#include <asm-generic/errno.h>
-#include <boost/beast/http/fields.hpp>
#include <boost/beast/http/status.hpp>
#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
diff --git a/redfish-core/lib/eventservice_sse.hpp b/redfish-core/lib/eventservice_sse.hpp
index bfd97c1..7858269 100644
--- a/redfish-core/lib/eventservice_sse.hpp
+++ b/redfish-core/lib/eventservice_sse.hpp
@@ -11,6 +11,7 @@
#include "subscription.hpp"
#include <app.hpp>
+#include <boost/url/param.hpp>
#include <boost/url/params_base.hpp>
#include <event_service_manager.hpp>
diff --git a/redfish-core/lib/managers.hpp b/redfish-core/lib/managers.hpp
index 32dcff1..5932eb9 100644
--- a/redfish-core/lib/managers.hpp
+++ b/redfish-core/lib/managers.hpp
@@ -53,7 +53,6 @@
#include <string>
#include <string_view>
#include <utility>
-#include <vector>
namespace redfish
{
diff --git a/redfish-core/lib/processor.hpp b/redfish-core/lib/processor.hpp
index feb2236..7fe858f 100644
--- a/redfish-core/lib/processor.hpp
+++ b/redfish-core/lib/processor.hpp
@@ -7,7 +7,6 @@
#include "app.hpp"
#include "async_resp.hpp"
-#include "dbus_singleton.hpp"
#include "dbus_utility.hpp"
#include "error_messages.hpp"
#include "generated/enums/processor.hpp"
diff --git a/redfish-core/lib/redfish_v1.hpp b/redfish-core/lib/redfish_v1.hpp
index e9dd422..4b08b69 100644
--- a/redfish-core/lib/redfish_v1.hpp
+++ b/redfish-core/lib/redfish_v1.hpp
@@ -7,17 +7,18 @@
#include "error_messages.hpp"
#include "http_request.hpp"
#include "http_response.hpp"
+#include "human_sort.hpp"
#include "logging.hpp"
#include "query.hpp"
#include "registries/privilege_registry.hpp"
#include "str_utility.hpp"
-#include "utils/json_utils.hpp"
#include <boost/beast/http/field.hpp>
#include <boost/beast/http/status.hpp>
#include <boost/beast/http/verb.hpp>
#include <boost/url/format.hpp>
+#include <algorithm>
#include <array>
#include <filesystem>
#include <format>
diff --git a/redfish-core/lib/sensors.hpp b/redfish-core/lib/sensors.hpp
index ed6c247..97ee5fa 100644
--- a/redfish-core/lib/sensors.hpp
+++ b/redfish-core/lib/sensors.hpp
@@ -36,7 +36,6 @@
#include <algorithm>
#include <array>
-#include <cmath>
#include <cstddef>
#include <cstdint>
#include <functional>
diff --git a/redfish-core/lib/systems.hpp b/redfish-core/lib/systems.hpp
index 19d04b1..c6b6bb1 100644
--- a/redfish-core/lib/systems.hpp
+++ b/redfish-core/lib/systems.hpp
@@ -32,7 +32,6 @@
#include <boost/asio/error.hpp>
#include <boost/beast/http/field.hpp>
-#include <boost/beast/http/status.hpp>
#include <boost/beast/http/verb.hpp>
#include <boost/system/error_code.hpp>
#include <boost/system/linux_error.hpp>
diff --git a/redfish-core/src/subscription.cpp b/redfish-core/src/subscription.cpp
index f81fdc6..48e9c2c 100644
--- a/redfish-core/src/subscription.cpp
+++ b/redfish-core/src/subscription.cpp
@@ -32,8 +32,6 @@
#include <algorithm>
#include <chrono>
#include <cstdint>
-#include <cstdlib>
-#include <ctime>
#include <format>
#include <functional>
#include <memory>
diff --git a/src/webserver_run.cpp b/src/webserver_run.cpp
index feda8ad..a717a8d 100644
--- a/src/webserver_run.cpp
+++ b/src/webserver_run.cpp
@@ -18,6 +18,7 @@
#include "login_routes.hpp"
#include "obmc_console.hpp"
#include "openbmc_dbus_rest.hpp"
+#include "persistent_data.hpp"
#include "redfish.hpp"
#include "redfish_aggregator.hpp"
#include "user_monitor.hpp"
diff --git a/test/include/multipart_test.cpp b/test/include/multipart_test.cpp
index f3e38fe..43f0fcb 100644
--- a/test/include/multipart_test.cpp
+++ b/test/include/multipart_test.cpp
@@ -3,8 +3,6 @@
#include "http_request.hpp"
#include "multipart_parser.hpp"
-#include <boost/beast/http/fields.hpp>
-
#include <iterator>
#include <string_view>
#include <system_error>