commit 3a4994147e856fe5fd39f744b1bdf8d57ed7267b
author Ed Tanous <ed@tanous.net> Wed Jun 05 16:05:35 2024 -0700
committer Ed Tanous <ed@tanous.net> Tue Jun 25 17:42:25 2024 +0000
tree dbf08fc6314012acb492424645f75066d882ae0a
parent 0bdda665a3589924e1f5a51d7ff8633c6544ffa1

Remove isSecure flag

There's nowhere this is used anymore;  Nothing dealing with things at a
Request/Response level should have to care about whether the transport
was TLS or not.

Previously it was used for some HTTP/HTTPS redirection logic, but that
logic has been gone for many years.

Tested: Code compiles.

Change-Id: Id95bab1f9dce0168505b1377b833008b3a18a948
Signed-off-by: Ed Tanous <ed@tanous.net>

http/http2_connection.hpp

diff --git a/http/http2_connection.hpp b/http/http2_connection.hpp
index 446c38f..a863636 100644
--- a/http/http2_connection.hpp
+++ b/http/http2_connection.hpp
@@ -490,9 +490,7 @@
         {
             BMCWEB_LOG_DEBUG("create stream for id {}", frame.hd.stream_id);
 
-            Http2StreamData& stream = streams[frame.hd.stream_id];
-            // http2 is by definition always tls
-            stream.req->isSecure = true;
+            streams.emplace(frame.hd.stream_id, Http2StreamData());
         }
         return 0;
     }

http/http_request.hpp

diff --git a/http/http_request.hpp b/http/http_request.hpp
index d2a1e25..55387d4 100644
--- a/http/http_request.hpp
+++ b/http/http_request.hpp
@@ -25,8 +25,6 @@
     boost::urls::url urlBase;
 
   public:
-    bool isSecure{false};
-
     boost::asio::io_context* ioService = nullptr;
     boost::asio::ip::address ipAddress;
 
@@ -67,7 +65,6 @@
     {
         req.clear();
         urlBase.clear();
-        isSecure = false;
         ioService = nullptr;
         ipAddress = boost::asio::ip::address();
         session = nullptr;