tree 783678a151e2e361983d81d67fd1a085607e8d41
parent 03810a1136e63aaf05ef9d9a15a551050daf825a
author Szymon Dompke <szymon.dompke@intel.com> 1645534680 +0100
committer Ed Tanous <ed@tanous.net> 1655317690 +0000

Fix Trigger GET functionality

Due to changes in dbus interface of TelemetryService, some modifications
were needed in bmcweb:
- Some of values in TriggerActions property were renamed.
- ReportNames property was renamed and its type was changed. It is now a
  vector of object_path, each representing full dbus path of a Report
  Telemetry resource. Some additional logic was added to verify it.

Additionally, 2 issues were found during testing:
- In case of error occurring during internal data parsing, GET could
  return both "Internal Error" message and incomplete Trigger
  representation. By swapping few lines of code, this issue is fixed:
  now either error is returned or full Trigger representation, but never
  both of them.
- NumericThresholds object was parsed as 'null' in case of missing
  thresholds. It should be an empty json {} instead.

Testing done:
- TriggerActions are properly translated to redfish names.
- Links are now returning proper uris of existing MRD.
- Internal Error is returned for malformed data returned by service.
- Other Trigger GET functionality remained unchanged.

Signed-off-by: Szymon Dompke <szymon.dompke@intel.com>
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I81ebbf3889a152199bef7230de56a73bb112731b