commit 452bd8d820151f294f3f735c2b6728351b3af265
author Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Tue Apr 18 12:28:38 2023 +0000
committer Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Tue May 02 18:18:55 2023 +0000
tree 4c49d4d49487625f0243233bd1dc4f24a11407fb
parent 46b302837c3c44376da3ba6b72fb70b7b2ce1c11

virtual_media: Fix for bmcweb crash

bmcweb crashes when user not providing userName or password while
posting ISO form Redfish.

This fix provides to avoid bmcweb crash when user try to post ISO images
from Redfish without providing username or password.

Tested:
Redfish validator passed with this change.
Verified by Posting ISO from Redfish.

Signed-off-by: Arun Kapale <arunx.kapale@intel.com>
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ib9c7ed668f13943bdacdd9afda0e65d6bcc438d0

redfish-core/lib/virtual_media.hpp

diff --git a/redfish-core/lib/virtual_media.hpp b/redfish-core/lib/virtual_media.hpp
index bb17d3f..96fd037 100644
--- a/redfish-core/lib/virtual_media.hpp
+++ b/redfish-core/lib/virtual_media.hpp
@@ -769,6 +769,16 @@
             *actionParams.imageUrl, *paramTransferProtocolType);
     }
 
+    if (!actionParams.userName)
+    {
+        actionParams.userName = "";
+    }
+
+    if (!actionParams.password)
+    {
+        actionParams.password = "";
+    }
+
     doMountVmLegacy(asyncResp, service, resName, *actionParams.imageUrl,
                     !(*actionParams.writeProtected),
                     std::move(*actionParams.userName),