Fix constexpr on clang
clang correctly notes that this branch is impossible to hit on 32 bit
systems, so wrap it in an if contexpr check to check for 32 bit, and
avoid the next branch entirely.
Tested: code compiles further on clang. Unit tests pass.
Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iccaab8402d839faa7c3f7cea457ef6bcba832f67
diff --git a/http/utility.hpp b/http/utility.hpp
index 37c06cd..6c4cfb7 100644
--- a/http/utility.hpp
+++ b/http/utility.hpp
@@ -616,9 +616,12 @@
inline std::string getDateTimeStdtime(std::time_t secondsSinceEpoch)
{
- if (secondsSinceEpoch > static_cast<int64_t>(details::maxSeconds))
+ constexpr static std::time_t timeTMax =
+ std::numeric_limits<std::time_t>::max();
+ if constexpr (std::cmp_greater(timeTMax, details::maxSeconds))
{
- secondsSinceEpoch = static_cast<std::time_t>(details::maxSeconds);
+ secondsSinceEpoch = std::min(static_cast<int64_t>(details::maxSeconds),
+ secondsSinceEpoch);
}
boost::posix_time::ptime time =
boost::posix_time::from_time_t(secondsSinceEpoch);