commit 47f2934cc509e420e5617a96158e76829746b835
author Ed Tanous <ed@tanous.net> Tue Mar 19 12:18:06 2024 -0700
committer Ed Tanous <ed@tanous.net> Mon Mar 25 18:29:19 2024 +0000
tree dd73fdb8eb071886f4de28a0a911972d6ce4940f
parent 0501696e3663eafb3e497120b85f0f0a8194a97b

Fix redundant init issues

clang-tidy-18 must've fixed their checking for these in headers.
Resolve as the robot commands.

Tested: Noop changes made by tidy.  Code compiles.

Change-Id: I1de7686c597deffb0df91c30dae1a29f9ba7900e
Signed-off-by: Ed Tanous <ed@tanous.net>

http/http2_connection.hpp

diff --git a/http/http2_connection.hpp b/http/http2_connection.hpp
index 7903ec9..749ac28 100644
--- a/http/http2_connection.hpp
+++ b/http/http2_connection.hpp
@@ -38,9 +38,9 @@
 
 struct Http2StreamData
 {
-    Request req{};
+    Request req;
     std::optional<bmcweb::HttpBody::reader> reqReader;
-    Response res{};
+    Response res;
     std::optional<bmcweb::HttpBody::writer> writer;
 };
 

http/http_request.hpp

diff --git a/http/http_request.hpp b/http/http_request.hpp
index ee940d6..a3c8fd8 100644
--- a/http/http_request.hpp
+++ b/http/http_request.hpp
@@ -22,17 +22,17 @@
     boost::beast::http::request<bmcweb::HttpBody> req;
 
   private:
-    boost::urls::url urlBase{};
+    boost::urls::url urlBase;
 
   public:
     bool isSecure{false};
 
-    boost::asio::io_context* ioService{};
-    boost::asio::ip::address ipAddress{};
+    boost::asio::io_context* ioService = nullptr;
+    boost::asio::ip::address ipAddress;
 
     std::shared_ptr<persistent_data::UserSession> session;
 
-    std::string userRole{};
+    std::string userRole;
     Request(boost::beast::http::request<bmcweb::HttpBody> reqIn,
             std::error_code& ec) :
         req(std::move(reqIn))