Fix redundant init issues
clang-tidy-18 must've fixed their checking for these in headers.
Resolve as the robot commands.
Tested: Noop changes made by tidy. Code compiles.
Change-Id: I1de7686c597deffb0df91c30dae1a29f9ba7900e
Signed-off-by: Ed Tanous <ed@tanous.net>
diff --git a/redfish-core/include/utils/query_param.hpp b/redfish-core/include/utils/query_param.hpp
index 881b090..fa2b4da 100644
--- a/redfish-core/include/utils/query_param.hpp
+++ b/redfish-core/include/utils/query_param.hpp
@@ -180,7 +180,10 @@
std::optional<size_t> top = std::nullopt;
// Select
- SelectTrie selectTrie = {};
+ // Unclear how to make this use structured initialization without this.
+ // Might be a tidy bug? Ignore for now
+ // NOLINTNEXTLINE(readability-redundant-member-init)
+ SelectTrie selectTrie{};
};
// The struct defines how resource handlers in redfish-core/lib/ can handle
diff --git a/redfish-core/lib/account_service.hpp b/redfish-core/lib/account_service.hpp
index d897fcd..ab9048a 100644
--- a/redfish-core/lib/account_service.hpp
+++ b/redfish-core/lib/account_service.hpp
@@ -63,14 +63,14 @@
struct LDAPConfigData
{
- std::string uri{};
- std::string bindDN{};
- std::string baseDN{};
- std::string searchScope{};
- std::string serverType{};
+ std::string uri;
+ std::string bindDN;
+ std::string baseDN;
+ std::string searchScope;
+ std::string serverType;
bool serviceEnabled = false;
- std::string userNameAttribute{};
- std::string groupAttribute{};
+ std::string userNameAttribute;
+ std::string groupAttribute;
std::vector<std::pair<std::string, LDAPRoleMapData>> groupRoleList;
};
diff --git a/redfish-core/lib/metric_report_definition.hpp b/redfish-core/lib/metric_report_definition.hpp
index f68abdc..643fd52 100644
--- a/redfish-core/lib/metric_report_definition.hpp
+++ b/redfish-core/lib/metric_report_definition.hpp
@@ -763,7 +763,7 @@
private:
std::shared_ptr<bmcweb::AsyncResp> asyncResp;
AddReportArgs args;
- boost::container::flat_map<std::string, std::string> uriToDbus{};
+ boost::container::flat_map<std::string, std::string> uriToDbus;
};
class UpdateMetrics
@@ -881,7 +881,7 @@
const std::shared_ptr<bmcweb::AsyncResp> asyncResp;
std::vector<std::vector<std::string>> readingParamsUris;
- ReadingParameters readingParams{};
+ ReadingParameters readingParams;
};
inline void