commit 482c45a52e221882be5142a873cd828c380d7e54
author Josh Lehan <krellan@google.com> Tue Mar 29 17:10:44 2022 -0700
committer Ed Tanous <ed@tanous.net> Thu May 12 23:23:34 2022 +0000
tree a6451f283092a705f0cc201e6ed620a1807c5314
parent 1476687deb1697d865b20458a0097c9ab5fd44e2

Separate validFilename into a separate function

This will generalize it and make it callable from other places

Tested: Added test cases, they pass

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I8df30d6fe6753a2454d7051cc2d8813ddbf14bad

include/ut/openbmc_dbus_rest_test.cpp

diff --git a/include/ut/openbmc_dbus_rest_test.cpp b/include/ut/openbmc_dbus_rest_test.cpp
new file mode 100644
index 0000000..e671e47
--- /dev/null
+++ b/include/ut/openbmc_dbus_rest_test.cpp
@@ -0,0 +1,35 @@
+#include "include/openbmc_dbus_rest.hpp"
+
+#include "gtest/gtest.h"
+
+// Also see redfish-core/ut/configfile_test.cpp
+TEST(OpenbmcDbusRestTest, ValidFilenameGood)
+{
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("GoodConfigFile"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("_Underlines_"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("8675309"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("-Dashes-"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("With Spaces"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("One.Dot"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("trailingdot."));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename("-_ o _-"));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename(" "));
+    EXPECT_TRUE(crow::openbmc_mapper::validateFilename(" ."));
+}
+
+// There is no length test yet because validateFilename() does not care yet
+TEST(OpenbmcDbusRestTest, ValidFilenameBad)
+{
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename(""));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("Bad@file"));
+    EXPECT_FALSE(
+        crow::openbmc_mapper::validateFilename("/../../../../../etc/badpath"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("/../../etc/badpath"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("/mydir/configFile"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("/"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename(".leadingdot"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("Two..Dots"));
+    EXPECT_FALSE(
+        crow::openbmc_mapper::validateFilename("../../../../../../etc/shadow"));
+    EXPECT_FALSE(crow::openbmc_mapper::validateFilename("."));
+}